Re: [Differential] [Commented On] D1764: Factor out ip6_deletefraghdr()

2015-02-15 Thread Alfred Perlstein
Can you use the commit log string and try that? Sent from my iPhone > On Feb 15, 2015, at 5:32 PM, glebius (Gleb Smirnoff) > wrote: > > glebius added a comment. > > Damn f*ckbrikator doesn't allow me to close the revision, since I don't own > it. > > Kristof, looks like you will need to ma

[Differential] [Commented On] D1764: Factor out ip6_deletefraghdr()

2015-02-15 Thread glebius (Gleb Smirnoff)
glebius added a comment. Damn f*ckbrikator doesn't allow me to close the revision, since I don't own it. Kristof, looks like you will need to manually close all your revisions as I commit them. Or we can just leave some trash in this "pretty" software. REVISION DETAIL https://reviews.freebsd.

[Differential] [Commented On] D1764: Factor out ip6_deletefraghdr()

2015-02-12 Thread kristof (Kristof Provost)
kristof added a comment. Most of the remarks apply to the previous code as well. I have a minor preference for the patch to be a straight move of the existing code. If you feel strongly we should to take the opportunity to do style cleanups I will of course do so. I could also do the cleanups in