https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #25 from Cy Schubert ---
Rearranging input arguments breaks checksum.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #24 from Cy Schubert ---
The problem was that the following fix in 2009, ip_fil.h r1.31 and fil.c r1.53,
is incomplete. A number of issues not relating to this PR have already been
fixed. The posted patch directly fixes this PR.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
Cy Schubert changed:
What|Removed |Added
Attachment #205808|0 |1
is obsolete|
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #22 from Cy Schubert ---
Hmmm. I am not able to reproduce the bug on real hardware or in a VM any more.
--
You are receiving this mail because:
You are on the CC list for the bug.
__
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #21 from WHR ---
(In reply to Cy Schubert from comment #20)
Unfortunately this bug is still happening in r350024.
I has verified that the source code I compiling contain your recent 3 commits
(349978, 349979, 349980); and I do
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
Cy Schubert changed:
What|Removed |Added
Attachment #205744|0 |1
is obsolete|
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #19 from Cy Schubert ---
I will produce an improved patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
Cy Schubert changed:
What|Removed |Added
Attachment #205322|0 |1
is obsolete|
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #17 from Cy Schubert ---
To be more precise (since I converted Darren's CVS tree to GIT), the CVS rev
number reported by cvs blame for ip_fil.h.
1.31 (darren_r 01-Mar-09)
--
You are receiving this mail because:
You ar
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #16 from Cy Schubert ---
This was broken by ipfilter commit c8beabe in 2009. fr_cksum was moved from the
end of frentry_t to before fr_func. It's a wonder any rule compares work.
--
You are receiving this mail because:
You are
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #15 from Cy Schubert ---
That's perfect, thank you. I'll do some testing here. I suspect the cause is
similar to a panic I am working on. Use your patch or the improved patch I
posted here while I dig into the root cause.
--
Y
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #14 from WHR ---
Good news. I has reproduced this bug in a FreeBSD 13.0-CURRENT r349753 testing
VM.
The steps are:
kldload ipl.ko
ifconfig tun0 plumb
ifconfig tun1 plumb
echo "pass in quick reply-to tun0:10.1.1.1 on tun0 proto
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #13 from Cy Schubert ---
Unfortunately I cannot accept patches until I can reproduce the problem here. I
have tested the rule in a VM with INVARIANTS and on my production firewall
without INVARIANTS. I am unable to verify that t
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #12 from WHR ---
(In reply to Cy Schubert from comment #11)
Although this bug is always reproduce on that particular machine, with both
12.0-STABLE and 13.0-CURRENT kernels, I failed to reproduce it on a testing VM.
I plan to i
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #11 from Cy Schubert ---
Unfortunately I cannot accept a patch for something I cannot reproduce. AFAIAC
your patch does not fix any bug. Help me reproduce it here then.
A patch for something I cannot verify or reproduce is not
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
WHR changed:
What|Removed |Added
Status|Closed |Open
Resolution|Not A Bug
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
Cy Schubert changed:
What|Removed |Added
Resolution|--- |Not A Bug
Status|Open
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
WHR changed:
What|Removed |Added
Version|12.0-STABLE |CURRENT
--
You are receiving this mail beca
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #8 from WHR ---
(In reply to Cy Schubert from comment #5)
> there is no need for this patch. It already works.
Why?
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
WHR changed:
What|Removed |Added
Resolution|Not A Bug |---
Status|Closed
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #6 from commit-h...@freebsd.org ---
A commit references this bug:
Author: cy
Date: Wed Jul 3 17:09:43 UTC 2019
New revision: 349655
URL: https://svnweb.freebsd.org/changeset/base/349655
Log:
MFC r349401:
While working on
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
Kubilay Kocak changed:
What|Removed |Added
Flags|mfc-stable11?, |
|mfc-stable12?
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
Cy Schubert changed:
What|Removed |Added
Resolution|--- |Not A Bug
Status|Open
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #4 from Cy Schubert ---
Created attachment 205341
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=205341&action=edit
Updated patch
I suppose I'll post my version of your patch. I'm far from finished, I'm still
digging
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #3 from WHR ---
I'm actually didn't noticed that 'fd_local' is just been set but not used in
the code; but it doesn't cause the issue in my test, 'fd_local' is 0 in all
rules.
By inserting printf(8)s to 'ipf_rule_compare', and m
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #2 from commit-h...@freebsd.org ---
A commit references this bug:
Author: cy
Date: Wed Jun 26 00:53:49 UTC 2019
New revision: 349401
URL: https://svnweb.freebsd.org/changeset/base/349401
Log:
While working on PR/238796 I disc
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #1 from Cy Schubert ---
Thanks for the patch. It is being reviewed along with the bug itself.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
Cy Schubert changed:
What|Removed |Added
Assignee|n...@freebsd.org |c...@freebsd.org
--
You are receiv
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
Kubilay Kocak changed:
What|Removed |Added
Status|New |Open
Assignee|b...@freeb
29 matches
Mail list logo
