https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
Gleb Smirnoff changed:
What|Removed |Added
Assignee|n...@freebsd.org |gleb...@freebsd.org
--
You are r
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
Mark Linimon changed:
What|Removed |Added
Flags|mfc-stable10?, mfc-stable9? |
Keywords|patch
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #19 from Alfred Perlstein ---
For now it makes sense to implement the sysctls as described in comment #15.
changing the behavior at this point seems a bad idea.
--
You are receiving this mail because:
You are the assignee for
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #18 from Cameron Sparr ---
@Alfred, I guess on Linux there is no way to warn about that, users would have
to check the buffer size limits themselves.
In conclusion, should I change my patch to do what you originally suggested?
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #17 from Alfred Perlstein ---
That is interesting... how to applications warn "your system doesn't have
sufficient buffering enabled for performance" ?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #16 from Cameron Sparr ---
I forgot that it's actually spelled out pretty clearly in the comments of the
code:
/* Don't error on this BSD doesn't and if you think
* about it this is right. Otherwise apps have to
* play 'guess
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #15 from Alfred Perlstein ---
> Re (1) do you mean that when kern.ipc.maxsockbuf gets set, scale the sb_max
> value up by the inverse of sb_max_adj? ie, kern.ipc.maxsockbuf * 2304 / 2048.
> In that case, setting kern.ipc.maxso
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #14 from Cameron Sparr ---
@Alfred, thanks for the background info
Re (1) do you mean that when kern.ipc.maxsockbuf gets set, scale the sb_max
value up by the inverse of sb_max_adj? ie, kern.ipc.maxsockbuf * 2304 / 2048.
In tha
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
Alfred Perlstein changed:
What|Removed |Added
CC||alf...@freebsd.org
--- Comment
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #12 from Kubilay Kocak ---
Looks like I missed the review creation, ignore my last comment, except for the
'needs a committer/assignee' bit ;D
--
You are receiving this mail because:
You are the assignee for the bug.
_
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
Kubilay Kocak changed:
What|Removed |Added
Keywords|needs-patch |patch
--- Comment #11 from Kubilay
cameronsparr_gmail.com updated the summary for this revision.
REVISION DETAIL
https://reviews.freebsd.org/D4129
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: cameronsparr_gmail.com, Contributor Reviewers, network
Cc: freebsd-net-list, imp
cameronsparr_gmail.com removed rS FreeBSD src repository as the repository for
this revision.
cameronsparr_gmail.com updated this revision to Diff 10121.
cameronsparr_gmail.com added a comment.
spaces to tabs
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D4129?vs=10120&id=10121
REV
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #10 from Cameron Sparr ---
Got it, thanks for the link, I put up a review on phabricator. May I suggest
you put a link to the wiki (https://wiki.freebsd.org/CodeReview) on the
homepage of the phabricator site? Looks like you can
cameronsparr_gmail.com added a reviewer: network.
cameronsparr_gmail.com added a subscriber: freebsd-net-list.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D4129
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: camerons
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
Cameron Sparr changed:
What|Removed |Added
URL|https://github.com/sparrc/f |https://reviews.freebsd.org
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #9 from NGie Cooper ---
This wiki page describes how our current code review process works:
https://wiki.freebsd.org/CodeReview
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #8 from Allan Jude ---
There is a command line tool for Phabricator called 'arcanist'
(devel/php5-arcanist) that simplifies posting patches to PHabriactor. It works
with svn and git.
Or, via the Phabricator web interface, you c
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #7 from Cameron Sparr ---
@Kubilay I realized that I actually have no idea how to use svn/phabricator, so
I'm just going to attach a patch to this case. Let me know how it looks, thank
you.
--
You are receiving this mail becau
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
--- Comment #6 from Cameron Sparr ---
Created attachment 163023
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=163023&action=edit
Patch of the diff in the URL section. Changes behavior of setsockopt
This change makes it so that
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
Kubilay Kocak changed:
What|Removed |Added
Flags||mfc-stable9?, mfc-stable10?
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
Hiren Panchasara changed:
What|Removed |Added
CC||gleb...@freebsd.org,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204438
NGie Cooper changed:
What|Removed |Added
Assignee|freebsd-b...@freebsd.org|freebsd-net@FreeBSD.org
23 matches
Mail list logo
