oleg added a comment.
AFAIR those changes were done for _callout_stop_safe() aka
callout_(stop|drain).
callout_reset_sbt_on() is not affected.
REVISION DETAIL
https://reviews.freebsd.org/D1777
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: rrs, kib
oleg added a comment.
Please correct me if i'm wrong but there is ref leakage. In particular:
"If the callout was restarted, the pending bit will be back on and"
agree.
"we just want to bail"
no, i would say we should do LLE_REMREF(lle) first, then unlock/return
because this one
oleg added a reviewer: sbahra_repnop.org.
REVISION DETAIL
https://reviews.freebsd.org/D8637
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: oleg, kmacy, kib, alc, sbahra_repnop.org
Cc: emaste, freebsd-net-list
___
oleg updated this revision to Diff 22728.
oleg added a comment.
1. fix issues reported by sbahra_repnop.org here:
https://reviews.freebsd.org/D1945
2. fix synchronization chain (producer -> producer -> consumer) noted by alc.
3. massive comments.
CHANGES SINCE LAST UPDATE
https://review
oleg added a comment.
In https://reviews.freebsd.org/D8637#180625, @alc wrote:
> Have you looked at https://reviews.freebsd.org/D1945, in particular, the
most recent postings by sbahra_repnop.org? It's not clear to me that these
changes will address the problem described in sbahra_repno
oleg created this revision.
oleg added reviewers: kmacy, alc, kib.
oleg added a subscriber: freebsd-net-list.
REVISION SUMMARY
Properly use acqure/release atomics.
REVISION DETAIL
https://reviews.freebsd.org/D8637
AFFECTED FILES
sys/sys/buf_ring.h
EMAIL PREFERENCES
https://reviews.freeb
