[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org marked 6 inline comments as done. jhujhiti_adjectivism.org added inline comments. INLINE COMMENTS > asomers wrote in icmp6.c:2147 > No. According to the comment at the bottom of icmp6_error, it isn't, because > icmp6_reflect can sometimes be called from the output path.

[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org added a comment. Forgot to change the other tests - this ought to do it. One annoying detail: while running these tests, I noticed intermittent failures on the SLAAC test. I was reminded of a similar intermittent issue I had while developing this: for reasons I c

[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org updated this revision to Diff 26053. jhujhiti_adjectivism.org marked 14 inline comments as done. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9451?vs=26022&id=26053 REVISION DETAIL https://reviews.freebsd.org/D9451 AF

[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org added inline comments. INLINE COMMENTS > asomers wrote in nd6.c:1295 > Yep, it's true. One way is to do it with static routes. Another way > involves changing the interfaces's fib. For example, like this: > > ifconfig tap0 create > ifconfig tap0 10.1.0.1/24 fib 2

[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org updated this revision to Diff 26022. jhujhiti_adjectivism.org marked an inline comment as done. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9451?vs=25512&id=26022 REVISION DETAIL https://reviews.freebsd.org/D9451 AFF

[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org added inline comments. INLINE COMMENTS > asomers wrote in nd6.c:1295 > Remember, the interface fib only matters for forwarding packets. It's > totally valid for an interface to have multiple addresses assigned, each of > which is on a different fib. So, to correctly d

[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org added a comment. I've updated the patch to address these points aside from the open question about determining neighborship. I think the testcase for default router advertisement should look something like this. I'm more familiar with epair interfaces than tap, b

[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org updated the summary for this revision. jhujhiti_adjectivism.org updated this revision to Diff 25512. jhujhiti_adjectivism.org marked 13 inline comments as done. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9451?vs=24782&i

[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org marked 6 inline comments as done. jhujhiti_adjectivism.org added a comment. As I mentioned in the PR, this is my first attempt at kernel work, so I very much appreciate the comments. I'll go ahead and update the review summary at my next opportunity. The testcase

[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org updated this revision to Diff 24782. jhujhiti_adjectivism.org added a comment. Here's the same patch with full context REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9451?vs=24768&id=24782 REVISION DETAIL https://rev

[Differential] D9451: Constrain IPv6 interface routes to each FIB

jhujhiti_adjectivism.org created this revision. jhujhiti_adjectivism.org added reviewers: asomers, network. jhujhiti_adjectivism.org added a subscriber: freebsd-net-list. jhujhiti_adjectivism.org set the repository for this revision to rS FreeBSD src repository. Herald added subscribers: ae, imp.