hrs requested changes to this revision.
hrs added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ng_ksocket.c:319
> +
> + for (i = 0; i < 8; i++) {
> + u_long val;
inet_pton in libkern should be used to parse
hrs added a comment.
Adding jumbo frame support looks good to me. However, is it better to
support this in ether_ioctl() instead of a driver-specific ioctl handler?
Check of (ifr->ifr_mtu > ETHERMTU) in ether_ioctl() can be changed to check if
the interface has IFCAP_JUMBO_MTU
hrs added a comment.
The cause is that the prefix route was removed by in_scrubprefix() in the
PRC_IFDOWN handler and never reinstalled upon PRC_IFUP because the
reinstallation is done only for ifa passed to SIOCAIFADDR. Just calling
if_up(ifp) looks too heavy to me because it causes
hrs added inline comments.
INLINE COMMENTS
sys/net/if_lagg.c:753 Please separate a llq loop from a handler for per-port
configuration. A llq traversal should be required only once in lagg_port_ops()
if the handlers process a single lagg_llq entry.
sys/net/if_lagg.c:837 Is this (llq == NULL
hrs added a subscriber: hrs.
hrs added a comment.
It is true that this LOR is driver-specific but calling SIOCSIFMTU after
acquiring a lock in lagg ioctl is not always safe. Change of lladdr suffers
from the same situation and it was solved by using an asynchronous task queue
to update
Synopsis: [ip6] IPv6 TCP connection hangs/drops when time/clock on the client
is stepped backwards
State-Changed-From-To: open->analyzed
State-Changed-By: hrs
State-Changed-When: Thu May 10 23:42:14 UTC 2012
State-Changed-Why:
I'll take this.
Responsible-Changed-From-To: freebsd-
Synopsis: [route] Route messages sent to all socket listeners regardless of
setfib(1)
Responsible-Changed-From-To: freebsd-net->hrs
Responsible-Changed-By: hrs
Responsible-Changed-When: Sat Jul 16 15:46:50 UTC 2011
Responsible-Changed-Why:
I'll take this.
http://www.freebsd.org/c
Synopsis: [ip6] ipv6_pktinfo breaks IPV6_USE_MIN_MTU
Responsible-Changed-From-To: freebsd-net->hrs
Responsible-Changed-By: hrs
Responsible-Changed-When: Mon Jun 27 17:21:52 UTC 2011
Responsible-Changed-Why:
I'll take this.
http://www.freebsd.org/cgi/query-pr.cgi?p
Synopsis: [ip6] [patch] IPv6 DNS autoconfiguration (RFC6106 RDNSS and DNSSL)
Responsible-Changed-From-To: freebsd-net->hrs
Responsible-Changed-By: hrs
Responsible-Changed-When: Sun Apr 10 01:27:13 UTC 2011
Responsible-Changed-Why:
I'll take this.
http://www.freebsd.org/cgi/query-p
Synopsis: [ip6] route6d deletes site-local routes
Responsible-Changed-From-To: freebsd-net->hrs
Responsible-Changed-By: hrs
Responsible-Changed-When: Thu May 27 01:42:17 UTC 2010
Responsible-Changed-Why:
I'll take this.
http://www.freebsd.org/cgi/query-pr.cgi?p
Synopsis: [gif] incorrect EtherIP header format.
Responsible-Changed-From-To: freebsd-net->hrs
Responsible-Changed-By: hrs
Responsible-Changed-When: Thu Jul 17 21:47:32 UTC 2008
Responsible-Changed-Why:
I will handle this.
http://www.freebsd.org/cgi/query-pr.cgi?pr=125
Synopsis: [gif] incorrect EtherIP header format.
State-Changed-From-To: feedback->open
State-Changed-By: hrs
State-Changed-When: Sun Jun 29 08:21:04 UTC 2008
State-Changed-Why:
We have a concrete case now.
http://www.freebsd.org/cgi/query-pr.cgi?pr=125
Synopsis: [gif] incorrect EtherIP header format.
State-Changed-From-To: open->feedback
State-Changed-By: hrs
State-Changed-When: Sat Jun 28 18:57:46 UTC 2008
State-Changed-Why:
We need a detail about this issue from the PR originator.
http://www.freebsd.org/cgi/query-pr.cgi?pr=125
13 matches
Mail list logo
