onmail.com, committed by
glebius).
REPOSITORY
rG FreeBSD src repository
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D48204?vs=149039&id=149093
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D48204/new/
REVISION DETAIL
https://reviews.freebsd.org/D48204
AFFECTED FIL
glebius added inline comments.
INLINE COMMENTS
> p.mousavizadeh_protonmail.com wrote in ng_ksocket.c:62
> I am using `ifunit()` at line 352, and its function declared in
> . Maybe I think it's required due to my lack of knowledge,
> Should I remove it?
Sorry, I though it be
glebius added a comment.
Also, any meaningful change to a manual page requires bumping the .Dd value
at the beginning of the page to today's date.
REPOSITORY
rG FreeBSD src repository
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D48204/new/
REVISION DETAIL
glebius added inline comments.
INLINE COMMENTS
> ng_ksocket.c:62
> +#include
> +#include
> +
What does require if_var.h?
REPOSITORY
rG FreeBSD src repository
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D48204/new/
REVISION DETAIL
https://reviews.freebsd.org/D
glebius added a comment.
In D23788#523247 <https://reviews.freebsd.org/D23788#523247>, @neel_neelc.org
wrote:
> I still get "ngctl: send msg: Invalid argument" errors with the commands in
the Test Plan. Am I doing anything wrong?
Well, you've added 3 new
glebius requested changes to this revision.
glebius added a comment.
This revision now requires changes to proceed.
I got few minor comments.
INLINE COMMENTS
> ng_pppoe.c:1135
> + /* Generate a packet of that type. */
> + MGETHDR(m, M_NOWAIT
glebius accepted this revision.
This revision has a positive review.
REVISION DETAIL
https://reviews.freebsd.org/D9345
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: decui_microsoft.com, hselasky, sepherosa_gmail.com, cem, np, kmacy, kib
glebius added a comment.
I don't think that the patch is in the right direction. The problem comes
from historical behavior that assigning an address is implicit UP. For a modern
networking equipment it is a normal administrative situation that sysadmin
wants to assign an address
glebius accepted this revision.
glebius added a comment.
This revision has a positive review.
This looks correct to me. But I haven't reviewed the consequences of writing
directly to the "netmask", which is also shared with rarp.c and udp.c
Thanks!
REVISION
glebius requested changes to this revision.
glebius added a comment.
This revision now requires changes to proceed.
Thanks a lot, Nikos.
I've fixed the problem of sleeping in UMA on kldunload. It was out the scope of
the patch. I also committed the first part of the patch - mu
glebius added a comment.
Recently Nikos has asked questions on kernel debugging. So, I guess, he is
working.
REVISION DETAIL
https://reviews.freebsd.org/D1944
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: nvass-gmx.com, bz, zec, trociny, glebius
glebius added a subscriber: glebius.
glebius accepted this revision.
glebius added a reviewer: glebius.
glebius added a comment.
And I second on jch@ comment.
REVISION DETAIL
https://reviews.freebsd.org/D1982
To: harrison.grundy-astrodoggroup.com, gnn, adrian, jch, glebius
Cc: glebius
glebius added a comment.
Nikos,
acking that I see the patches. Right now I'm waiting for pf to stablize after
recent patches to fragment handling. Kristof is working on the known problem.
Meanwhile you can finish your patch moving from "almost there" to "there" :)
If yo
glebius added a comment.
Is it possible to add Mike Karels to this discussion?
REVISION DETAIL
https://reviews.freebsd.org/D1965
To: erj, gnn, jfvogel, adrian
Cc: glebius, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org
glebius added a subscriber: glebius.
glebius added a comment.
We can't and don't plan to preserve the driver KPI for the 11 branch. We
actually plan to change it very much, in sake of keeping it stable there
on. Please see on what is going on in the projects/ifnet branch.
So, I&#x
glebius added a reviewer: ken.
glebius added a comment.
This is Ken's code, we probably want him to look at. Looks like a remnant from
zero copy era.
REVISION DETAIL
https://reviews.freebsd.org/D1893
To: hselasky, pluknet, ae, np, melifaro, glebius, hrs, wollman, bryanv, rpaulo,
adria
glebius accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://reviews.freebsd.org/D1766
To: kristof, glebius
Cc: glebius, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman
glebius accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://reviews.freebsd.org/D1765
To: kristof, glebius
Cc: glebius, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman
glebius added a comment.
Thanks. Now let me complete universe with anonymous structs/unions on.
INLINE COMMENTS
sys/netpfil/pf/pf_norm.c:88 This line looks like cut-n-paste typo. Don't
hurry to fix, I am about to improve the code to use anonymous structure, which,
I hope, will be enable
glebius added a comment.
Damn f*ckbrikator doesn't allow me to close the revision, since I don't own it.
Kristof, looks like you will need to manually close all your revisions as I
commit them. Or we can just leave some trash in this "pretty" software.
REV
glebius accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://reviews.freebsd.org/D1764
To: kristof, ae, glebius
Cc: ae, glebius, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org
glebius added a subscriber: glebius.
glebius accepted this revision.
glebius added a reviewer: glebius.
glebius added a comment.
This revision is now accepted and ready to land.
Thanks. We also need someone working in netinet6 look into this.
INLINE COMMENTS
sys/netinet6/ip6_output.c:225
glebius accepted this revision.
glebius added a reviewer: glebius.
This revision is now accepted and ready to land.
REVISION DETAIL
https://reviews.freebsd.org/D1765
To: kristof, glebius
Cc: glebius, freebsd-net
___
freebsd-net@freebsd.org mailing
glebius added a subscriber: glebius.
glebius added a comment.
Kristof, big thanks for working on this. See my comments.
INLINE COMMENTS
sys/netpfil/pf/pf.c:366 This function can also be used not only for fragment
rbtree, but can also substitute the PF_ANEQ, PF_AEQ and could be considered to
glebius added a subscriber: glebius.
glebius accepted this revision.
glebius added a reviewer: glebius.
glebius added a comment.
This revision is now accepted and ready to land.
Thanks. Patch looks good to me, but see comments. We probably need a nod from a
IPv6 expert. I'll send link
Synopsis: mbuf leak
State-Changed-From-To: patched->closed
State-Changed-By: glebius
State-Changed-When: Wed Mar 5 03:52:09 UTC 2014
State-Changed-Why:
Doesn't affect 10.0-RELEASE.
http://www.freebsd.org/cgi/query-pr.cgi?pr=165903
___
fre
Synopsis: [vimage] [pf] Core dump with Packet filter and VIMAGE options compile
in a kernel
State-Changed-From-To: open->analyzed
State-Changed-By: glebius
State-Changed-When: Thu Jun 6 14:52:13 UTC 2013
State-Changed-Why:
There is work in progress in this area:
http://lists.freebsd.
Synopsis: [fxp] fxp network driver broken in 7.4
State-Changed-From-To: open->closed
State-Changed-By: glebius
State-Changed-When: Mon May 6 08:14:11 UTC 2013
State-Changed-Why:
I'm sorry, but 7.4-RELEASE isn't a supported release, its EoL
was February 28, 2013.
http://www.freebsd
Synopsis: [tcp] [panic] Kernel panic: general protection fault in tcp_do_segment
State-Changed-From-To: open->closed
State-Changed-By: glebius
State-Changed-When: Mon Apr 22 10:54:18 UTC 2013
State-Changed-Why:
Email to submitters address bounces.
http://www.freebsd.org/cgi/query-pr.cgi
Synopsis: mbuf leak
State-Changed-From-To: open->patched
State-Changed-By: glebius
State-Changed-When: Thu Apr 11 19:40:46 UTC 2013
State-Changed-Why:
Submitter reports, that problem can't be reproduced on 10.0-CURRENT
http://lists.freebsd.org/pipermail/freebsd-stable/2013-April/073
Synopsis: [tcp] [patch] An error of calculating TCP sequence number will
resault in the machine to restart
State-Changed-From-To: open->analyzed
State-Changed-By: glebius
State-Changed-When: Mon Apr 8 11:01:18 UTC 2013
State-Changed-Why:
Grab the PR. I've reproduced it.
Responsible
Synopsis: [libnetgraph] [patch] user-mode netgraph node hangs when replying to
control message
State-Changed-From-To: open->patched
State-Changed-By: glebius
State-Changed-When: Mon Mar 11 12:59:12 UTC 2013
State-Changed-Why:
Committed. Thanks for submission!
Responsible-Changed-From
Synopsis: [net] [if_bridge] [patch] use-after-free in if_bridge
State-Changed-From-To: open->patched
State-Changed-By: glebius
State-Changed-When: Mon Mar 11 12:00:29 UTC 2013
State-Changed-Why:
Committed, thanks.
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Chan
Synopsis: [udp] [panic] Kernel Panic in udp_input @ offset 0x475
State-Changed-From-To: open->closed
State-Changed-By: glebius
State-Changed-When: Tue Mar 5 09:36:16 UTC 2013
State-Changed-Why:
Fixed in stable/9 in r241435.
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-C
Synopsis: [ng_ubt] [patch] Add vendor IDs for Broadcom USB dongles (BCM20702)
State-Changed-From-To: open->patched
State-Changed-By: glebius
State-Changed-When: Wed Dec 26 15:04:32 UTC 2012
State-Changed-Why:
Committed, thanks!
Responsible-Changed-From-To: freebsd-net->glebius
Respo
Synopsis: [netinet] [patch] Incorrect IP checksums when forwarding results in
fragmentation
State-Changed-From-To: open->patched
State-Changed-By: glebius
State-Changed-When: Mon Nov 5 20:44:43 UTC 2012
State-Changed-Why:
Committed to head.
Responsible-Changed-From-To: freebsd-net->g
Synopsis: [panic] [netinet] [patch] in_lltable_prefix_free() races with
lla_lookup() and arptimer()
State-Changed-From-To: open->patched
State-Changed-By: glebius
State-Changed-When: Fri Aug 3 08:01:48 UTC 2012
State-Changed-Why:
Fix committed to head/.
Responsible-Changed-From-To: free
Synopsis: [netgraph]: ngctl(8) does not work as advertised
State-Changed-From-To: open->closed
State-Changed-By: glebius
State-Changed-When: Wed Mar 21 13:40:46 UTC 2012
State-Changed-Why:
Not a bug.
The code:
# ngctl mkpeer em0: netflow lower iface0
expects presense of em0: node. And
Synopsis: [route] ntpd(8): Repeating RTM_MISS packets causing high CPU load for
ntpd
Responsible-Changed-From-To: freebsd-net->freebsd-rc
Responsible-Changed-By: glebius
Responsible-Changed-When: Wed Feb 8 13:55:07 UTC 2012
Responsible-Changed-Why:
I think, that solution to the problem li
Synopsis: [netinet] [patch] [panic] VIMAGE + carp panics the kernel
State-Changed-From-To: open->closed
State-Changed-By: glebius
State-Changed-When: Wed Feb 8 13:38:23 UTC 2012
State-Changed-Why:
Fixed.
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: g
Synopsis: [flowtable] Flowtable excessively caches dest MAC addresses for
outgoing traffic
Responsible-Changed-From-To: freebsd-net->kmacy
Responsible-Changed-By: glebius
Responsible-Changed-When: Tue Jan 17 14:10:55 UTC 2012
Responsible-Changed-Why:
Over to author of flowtable.
h
Synopsis: [ng_mppc] ng_mppc_decompress - disabling node
State-Changed-From-To: feedback->closed
State-Changed-By: glebius
State-Changed-When: Thu Jan 5 13:33:16 UTC 2012
State-Changed-Why:
Email of submitter is no longer valid.
http://www.freebsd.org/cgi/query-pr.cgi?pr=123
Synopsis: [carp] CARP preemption mode traffic partially goes to backup node
State-Changed-From-To: open->closed
State-Changed-By: glebius
State-Changed-When: Mon Dec 19 08:28:54 UTC 2011
State-Changed-Why:
Closed per submitters request.
http://www.freebsd.org/cgi/query-pr.cgi?pr=144
Synopsis: [carp] CARP preemption mode traffic partially goes to backup node
State-Changed-From-To: closed->open
State-Changed-By: glebius
State-Changed-When: Tue Oct 18 08:15:18 UTC 2011
State-Changed-Why:
Submitter claims (via irc) that email problem is fixed.
http://www.freebsd.org/cgi/qu
Synopsis: [carp] ipv6 does not work on carp interfaces [regression]
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Sat Oct 15 14:26:48 UTC 2011
Responsible-Changed-Why:
I'm now working on major rewrite of CARP for FreeBSD 10,
Synopsis: [carp] [if_bridge] carp stuck in init when using bridge interface
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Sat Oct 15 14:25:17 UTC 2011
Responsible-Changed-Why:
I'm now working on major rewrite of CARP for Fr
Synopsis: [carp] CARP preemption mode traffic partially goes to backup node
State-Changed-From-To: open->closed
State-Changed-By: glebius
State-Changed-When: Sat Oct 15 14:21:53 UTC 2011
State-Changed-Why:
Submitter mail relay is not accepting a valid email.
- The following addresses
Synopsis: [carp] CARP arp replays with wrong src mac
State-Changed-From-To: open->analyzed
State-Changed-By: glebius
State-Changed-When: Sat Oct 15 09:08:48 UTC 2011
State-Changed-Why:
Let's look at this closer.
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-
Synopsis: [carp] [hang] use of carp(4) causes system to freeze
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Sat Oct 15 09:04:10 UTC 2011
Responsible-Changed-Why:
I'm now working on major rewrite of CARP for FreeBSD 10, and
Synopsis: [carp] alias gives incorrect hash in dmesg
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Sat Oct 15 09:02:28 UTC 2011
Responsible-Changed-Why:
I'm now working on major rewrite of CARP for FreeBSD 10, and
I'd lik
Synopsis: [carp] carp(4) advskew setting ignored when carp IP used on a gif(4)
interface
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Sat Oct 15 09:00:31 UTC 2011
Responsible-Changed-Why:
I'm now working on major rewrite of
Synopsis: [carp] [panic] Kernel panic with EtherIP (may be related to SVN
commit 178025)
State-Changed-From-To: open->feedback
State-Changed-By: glebius
State-Changed-When: Sat Oct 15 08:41:16 UTC 2011
State-Changed-Why:
Feedback requeted.
http://www.freebsd.org/cgi/query-pr.cgi?pr=129
Synopsis: [carp] CARP interface destruction with ifconfig destroy causes kernel
panic
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Sat Oct 15 08:34:57 UTC 2011
Responsible-Changed-Why:
I'm now working on major rewrite of
Synopsis: [carp] CARP interface renaming makes system no longer respond on the
virtual IP address
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Sat Oct 15 08:32:41 UTC 2011
Responsible-Changed-Why:
I'm now working on major re
Synopsis: [carp] [lagg] CARP combined with LAGG causes system panic - 7.0/amd64
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Sat Oct 15 08:30:56 UTC 2011
Responsible-Changed-Why:
I'm now working on major rewrite of CARP for
Synopsis: [carp] [panic] carp causes kernel panics in any constellation
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Sat Oct 15 08:19:31 UTC 2011
Responsible-Changed-Why:
I'm now working on major rewrite of CARP for FreeBSD
Synopsis: [carp] 6.2 kernel crash [regression]
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Sat Oct 15 08:17:15 UTC 2011
Responsible-Changed-Why:
I'm now working on major rewrite of CARP for FreeBSD 10, and
I'd lik
Synopsis: [carp] [patch] when preemption is enabled carp interface assumes
MASTERship immediately even with higher advbase/advskew
State-Changed-From-To: open->closed
State-Changed-By: glebius
State-Changed-When: Thu Oct 13 14:03:56 UTC 2011
State-Changed-Why:
Dup of kern/161123
h
Synopsis: [carp] [patch] when preemption is enabled carp interface assumes
MASTERship immediately even with higher advbase/advskew
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-Changed-When: Thu Oct 13 14:03:27 UTC 2011
Responsible-Changed-
Synopsis: [netgraph] [panic] HEAD, 8.1-RELEASE panic after some play with
netgraph
State-Changed-From-To: patched->closed
State-Changed-By: glebius
State-Changed-When: Thu Apr 21 08:11:52 UTC 2011
State-Changed-Why:
Merged to stable/8.
Responsible-Changed-From-To: freebsd-net->g
Synopsis: [netgraph] [panic] HEAD, 8.1-RELEASE panic after some play with
netgraph
State-Changed-From-To: open->patched
State-Changed-By: glebius
State-Changed-When: Fri Apr 15 10:02:54 UTC 2011
State-Changed-Why:
Fixed in head.
http://www.freebsd.org/cgi/query-pr.cgi?pr=154
Synopsis: [arp] [panic] RADIX_NODE_HEAD_LOCK_ASSERT in rtexpunge()
State-Changed-From-To: open->closed
State-Changed-By: glebius
State-Changed-When: Tue Apr 12 08:03:06 UTC 2011
State-Changed-Why:
The problem is fixed in the stable/8 branch.
http://www.freebsd.org/cgi/query-pr.cgi?pr=155
Synopsis: [arp] arp pub not working properly
State-Changed-From-To: open->closed
State-Changed-By: glebius
State-Changed-When: Tue Jul 27 10:06:08 UTC 2010
State-Changed-Why:
Dup of kern/148784
http://www.freebsd.org/cgi/query-pr.cgi?pr=146
Synopsis: [arp] arp pub not working properly
State-Changed-From-To: open->patched
State-Changed-By: glebius
State-Changed-When: Tue Jul 27 10:04:24 UTC 2010
State-Changed-Why:
Fixed in head/.
Responsible-Changed-From-To: freebsd-net->glebius
Responsible-Changed-By: glebius
Responsible-C
Synopsis: [netgraph] [patch] panic kernel when ng_ipfw send ip package on not
existing netgraph node
State-Changed-From-To: open->patched
State-Changed-By: glebius
State-Changed-When: Tue Jul 6 10:35:17 UTC 2010
State-Changed-Why:
Fixed in head/.
Responsible-Changed-From-To: freebsd-
Synopsis: [carp][patch] add carp userland notifications via devctl(4)
State-Changed-From-To: open->feedback
State-Changed-By: glebius
State-Changed-When: Fri Dec 5 14:37:54 UTC 2008
State-Changed-Why:
I've just committed a change that makes link state change announcement
when CARP change
66 matches
Mail list logo
