[Differential] [Commented On] D1697: sfxge: Expect required init_state on data path and in periodic calls

arybchik added a comment. I did measurements when implemented the patch and just retested once again using pmcstat instruction and BR_MISP_RETIRED.ALL_BRANCHES counters. With the patch applied the number of instruction events is 1% less and number of mispredicted branch events is 5% less. REVIS

[Differential] [Closed] D1691: sfxge: using 64-bit access for x86-64

arybchik closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1691 To: arybchik, gnn Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Commented On] D1691: sfxge: using 64-bit access for x86-64

arybchik added a comment. Committed to src head REVISION DETAIL https://reviews.freebsd.org/D1691 To: arybchik, gnn Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send an

[Differential] [Commented On] D1707: sfxge: access statistics buffers under port lock

arybchik added a comment. I've published review request D1772 to add macros. Please, review. Also I have a patch to make lock names unique - will follow. REVISION DETAIL https://reviews.freebsd.org/D1707 To: arybchik, gnn Cc: freebsd-net ___ freebsd-

[Differential] [Request, 151 lines] D1708: sfxge: Separate software Tx queue limit for non-TCP traffic

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Add separate software Tx queue limit for non-TCP traffic to make total limit higher and avoid local drops of TCP packets because of no backpressure. There is no point

[Differential] [Request, 30 lines] D1707: sfxge: access statistics buffers under port lock

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Allow access to statistics data not only from sysctl handlers. Submitted by: Boris Misenov Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISIO

[Differential] [Request, 15 lines] D1706: sfxge: implemented parameter to restrict RSS channels

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Submitted by: Artem V. Andreev Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1706 AFFECTED FILES sh

[Differential] [Request, 2 lines] D1705: sfxge: Use SFXGE_MODERATION to initialize event moderation

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1705 AFFECTED FILES sys/dev/sfxge/sfxge_ev.c To: arybchik

[Differential] [Request, 2 lines] D1704: sfxge: Pass correct address to free allocated memory in the case of load error

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Most likely is was just memory leak on the error handling path since typically efsys_mem_t is filled in by zeros on allocation. Sponsored by: Solarflare Communicati

[Differential] [Request, 1 lines] D1703: sfxge: Remove unused esm_size member of the efsys_mem_t structure

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY esm_size is not even initialized properly when memory is allocated. Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.f

[Differential] [Request, 2 lines] D1702: sfxge: Do not bzero() DMA allocated memory once again

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY sfxge_dma_alloc() calls bus_dmamem_alloc() with BUS_DMA_ZERO flag, so allocated memory is already filled in by zeros BRANCH /head REVISION DETAIL https://reviews.fre

[Differential] [Request, 17 lines] D1701: sfxge: Add evq argument to sfxge_tx_qcomplete()

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY It removes necessity to get evq pointer by its index in soft context. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1701 AFFECTED FILES sys/dev/sfxge/sf

[Differential] [Updated] D1692: sfxge: Change sfxge_ev_qpoll() proto to avoid EVQ pointers array access

arybchik set the repository for this revision to rS (FreeBSD src repository). REVISION DETAIL https://reviews.freebsd.org/D1692 To: arybchik, gnn Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebs

[Differential] [Request, 16 lines] D1700: sfxge: fixed TSO code to cope with VLAN headers

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Submitted by: Artem V. Andreev Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1700 AFFECTED FILES sy

[Differential] [Request, 20 lines] D1699: sfxge: Remove extra cache-line alignment and reorder sfxge_evq_t

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Remove the first member alignment to cacheline since it is nop. Use __aligned() for the whole structure to make sure that the structure size is cacheline aligned. Remo

[Differential] [Request, 14 lines] D1698: sfxge: Make it possible to build without EVQ statistics

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1698 AFFECTED FILES sys/dev/sfxge/common/efx_ev.c sys/de

[Differential] [Request, 35 lines] D1697: sfxge: Expect required init_state on data path and in periodic calls

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1697 AFFECTED FILES sys/dev/sfxge/sfxge_ev.c sys/dev/sfx

[Differential] [Request, 2 lines] D1694: sfxge: Move txq->next pointer to part writable on completion path

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY In fact the pointer is used only if more than one TXQ is processed in one interrupt. It is used (read-write) on completion path only. Also it makes the first part of

[Differential] [Request, 12 lines] D1692: sfxge: Change sfxge_ev_qpoll() proto to avoid EVQ pointers array access

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. arybchik set the repository for this revision to rS (FreeBSD src repository). REVISION SUMMARY It was the only place on data path where sc->evq array is accessed. Sponsored by: Solarf

[Differential] [Request, 195 lines] D1691: sfxge: using 64-bit access for x86-64

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. arybchik set the repository for this revision to rS (FreeBSD src repository). REVISION SUMMARY Submitted by: Artem V. Andreev Sponsored by: Solarflare Communications, Inc. REVISION D