This revision was automatically updated to reflect the committed changes.
Closed by commit rS324052: mbuf: Remove UDP_IPV4_EX, which was never defined.
(authored by sephe, committed by ).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D12453?vs=33300&id=33483#toc
REPOSITORY
rS FreeBSD s
ae added inline comments.
INLINE COMMENTS
> eugen_grosbein.net wrote in if_stf.c:383
> in_localip() may be better, I just wished to make the patch as clear as
> possible minizing changes for first revision.
Using in_localip() is preferred, because INADDR_HASH is protected with rmlock
only in h
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220078
Kubilay Kocak changed:
What|Removed |Added
Flags||mfc-stable11+
--
You are receivin
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220078
--- Comment #20 from commit-h...@freebsd.org ---
A commit references this bug:
Author: ae
Date: Wed Sep 27 01:47:54 UTC 2017
New revision: 324047
URL: https://svnweb.freebsd.org/changeset/base/324047
Log:
MFC r323839:
Use in_localip(
eugen_grosbein.net marked an inline comment as done.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D12457
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: eugen_grosbein.net, ae, avg, mav, rwatson
Cc: bz, imp, freebsd-ne
eugen_grosbein.net marked 2 inline comments as done.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D12457
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: eugen_grosbein.net, ae, avg, mav, rwatson
Cc: bz, imp, freebsd-ne
eugen_grosbein.net marked an inline comment as done.
eugen_grosbein.net added inline comments.
INLINE COMMENTS
> mav wrote in in_mcast.c:1383
> Do I miss some other protection means or this and few below places just
> scream about possible races due to missing interface pointer pulled out of
>
eugen_grosbein.net marked 2 inline comments as done.
eugen_grosbein.net added a comment.
In https://reviews.freebsd.org/D12457#258249, @rwatson wrote:
> Many of these changes are not sufficient to address the underlying problems
in this code, as the lock covers loop iteration but fails to
Hi Sepherosa,
I attached a dump. I can provide bigger dumps, but not in public,
because they might contain sensitive data.
The outgoing UDP packets are created by my fastd kernel module [1] that
is a simple UDP tunneling protocol that encapsulates IP packets using
M_PREPEND. Some code is simil
