[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

2015-03-01 Thread ae (Andrey V. Elsukov)
ae added a comment. >>! In D1986#7, @rstone wrote: > RLOCK only gets a read lock. You want WLOCK to get a write lock to ensure > serialization. Also we can use another lock in the lagg_ioctl, that will prevent simultaneous MTU changing. REVISION DETAIL https://reviews.freebsd.org/D1986 To:

[Differential] [Changed Subscribers] D1986: Teach lagg(4) to change MTU

2015-03-01 Thread emaste (Ed Maste)
emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1986 To: rpokala-panasas.com, rstone Cc: emaste, ae, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscr

[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

2015-03-01 Thread rstone (Ryan Stone)
rstone added inline comments. INLINE COMMENTS sys/net/if_lagg.c:1772 style(9) says to not include unnecessary braces (which I personally disagree with, but what can you do?) sys/net/if_lagg.c:1773 style(9): put brackets around the return value: return (0); sys/net/if_lagg.c:1811 I find

[Differential] [Updated] D1986: Teach lagg(4) to change MTU

2015-03-01 Thread rstone (Ryan Stone)
rstone added a comment. RLOCK only gets a read lock. You want WLOCK to get a write lock to ensure serialization. REVISION DETAIL https://reviews.freebsd.org/D1986 To: rpokala-panasas.com, rstone Cc: ae, freebsd-net ___ freebsd-net@freebsd.org maili

Re: Intel 82574L (em) [MultiQueue Support Fixes]

2015-03-01 Thread Sean Bruno
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/30/15 13:11, Sean Bruno wrote: > > http://www.intel.com/content/dam/doc/datasheet/82574l-gbe-controller-datasheet.pdf > > According to 7.1.11, this device does indeed have 2 queues for > stuff and or things. So, basic RSS would be possible i

[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

2015-03-01 Thread rpokala-panasas.com (Ravi Pokala)
rpokala-panasas.com added a comment. >>! In D1986#4, @ae wrote: > Just a thought. Imagine two interfaces, one has maximum MTU 2200, another > 1500. lagg0 has MTU 1400. > Two threads invokes changing MTU in the same time. One wants to change it to > 2000, another - to 1500. > It is possible, that

[Differential] [Accepted] D1982: Fix return errors in tcp_usrreq.c

2015-03-01 Thread jch (Julien Charbon)
jch accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1982 To: harrison.grundy-astrodoggroup.com, gnn, adrian, jch Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://list

[Differential] [Updated] D1982: Fix return errors in tcp_usrreq.c

2015-03-01 Thread harrison.grundy-astrodoggroup.com (Harrison Grundy)
harrison.grundy-astrodoggroup.com added a subscriber: freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1982 To: harrison.grundy-astrodoggroup.com, jch, gnn, adrian Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.

Call for testers: Fix incorrect error codes in connect()

2015-03-01 Thread Harrison Grundy
connect(), in both the man page and under POSIX is documented to only return EINVAL for invalid lengths of the namelen parameter, which is a fatal error. As it stands now, it will also return EINVAL when called on TIMEWAIT or DROPPED sockets. The patch at https://reviews.freebsd.org/D1982 changes

[Differential] [Commented On] D1965: Add extended media types to if_media.h and ifconfig

2015-03-01 Thread mike-karels.net (Mike Karels)
mike-karels.net added a comment. >>! In D1965#11, @gnn wrote: > BTW Mike Karels was in favor of this in an email thread. He's not yet on > phabricator but I'll ask him here as well. Agreed, with minor exceptions. Given the ixl changes, I don't think the vtnet example is worth keeping, and I th

[Differential] [Changed Subscribers] D1965: Add extended media types to if_media.h and ifconfig

2015-03-01 Thread mike-karels.net (Mike Karels)
mike-karels.net added a subscriber: mike-karels.net. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1965 To: erj, adrian, jfvogel, gnn Cc: mike-karels.net, glebius, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebs

[Differential] [Changed Subscribers] D1986: Teach lagg(4) to change MTU

2015-03-01 Thread ae (Andrey V. Elsukov)
ae added a subscriber: ae. ae added a comment. Just a thought. Imagine two interfaces, one has maximum MTU 2200, another 1500. lagg0 has MTU 1400. Two threads invokes changing MTU in the same time. One wants to change it to 2000, another - to 1500. It is possible, that when both threads will fin

[Bug 197997] [panic] ng_pppoe sometimes panics with trap 12 when server drops session

2015-03-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197997 --- Comment #2 from Lev A. Serebryakov --- (In reply to eugen from comment #1) No :( It is NanoBSD system without any space for crashump & with autoreboot. Only thing I have is posted panic message from "dmesg" buffer. I could mot reprodu