Re: ipfw named objejcts, table values and syntax change

2014-08-01 Thread Luigi Rizzo
On Fri, Aug 1, 2014 at 11:08 PM, Alexander V. Chernikov < melif...@freebsd.org> wrote: > Hello all. > > I'm currently working on to enhance ipfw in some areas. > The most notable (and user-visible) change is named table support. > The other one is support for different lookup algorithms for differ

Re: ipfw named objejcts, table values and syntax change

2014-08-01 Thread Julian Elischer
On 8/2/14, 5:08 AM, Alexander V. Chernikov wrote: Hello all. I'm currently working on to enhance ipfw in some areas. The most notable (and user-visible) change is named table support. The other one is support for different lookup algorithms for different key types. For example, new ipfw permits

ipfw named objejcts, table values and syntax change

2014-08-01 Thread Alexander V. Chernikov
Hello all. I'm currently working on to enhance ipfw in some areas. The most notable (and user-visible) change is named table support. The other one is support for different lookup algorithms for different key types. For example, new ipfw permits writing this: ipfw table tb1 create type cidr ipfw

Re: [PATCH] Implementation of draft-ietf-tcpm-newcwv-06

2014-08-01 Thread Adrian Chadd
Hi! This is looking better! Structurally though, I'd look at all those places where you only update tp->newcv and instead of passing in the tp, pass in a pointer to tp->newcv. That way you're keeping a lid on the scope of the helper functions - they only get access to as much data as they need so

[Bug 191520] [PATCH] Implementation of draft-ieft-tcpm-newcwv-06

2014-08-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191520 --- Comment #3 from Tom Jones --- Created attachment 145216 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=145216&action=edit Updated NewCWV patch Move NewCWV state into a struct within tcpcb -- You are receiving this mail bec

Re: [PATCH] Implementation of draft-ietf-tcpm-newcwv-06

2014-08-01 Thread Tom Jones
On Fri, Aug 01, 2014 at 03:19:20PM +0100, Tom Jones wrote: > > I have updated the patch to move the new variable introduced with newcwv into > a > struct within the tcpcb. Forgot some files in the diff. -- Tom | I don't see how we are going to build the dystopian megapoli @adventur

[Bug 191520] [PATCH] Implementation of draft-ieft-tcpm-newcwv-06

2014-08-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191520 --- Comment #2 from Tom Jones --- Comment on attachment 145214 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=145214 Updated NewCWV patch Updated the patch to move the NewCWV into a struct within tcpcb -- You are receiving thi

[Bug 191520] [PATCH] Implementation of draft-ieft-tcpm-newcwv-06

2014-08-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191520 --- Comment #1 from Tom Jones --- Created attachment 145214 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=145214&action=edit Updated NewCWV patch -- You are receiving this mail because: You are the assignee for the bug. __

Re: [PATCH] Implementation of draft-ietf-tcpm-newcwv-06

2014-08-01 Thread Tom Jones
On Mon, Jun 30, 2014 at 09:53:59PM +0100, Tom Jones wrote: > On Mon, Jun 30, 2014 at 12:29:44PM -0700, Adrian Chadd wrote: > > Hi! > > > > Cool! Would you mind throwing it into a bugzilla ticket so it's not > > lost and it can be assigned for some review? > > > > http://bugs.freebsd.org/submit/ >