Re: Include port number in "Listen queue overflow" messages

2014-03-18 Thread Julian Elischer
On 3/18/14, 8:33 PM, George Neville-Neil wrote: On Mar 7, 2014, at 1:23 , hiren panchasara wrote: I am thinking of committing following change that includes port number in "Listen queue overflow" messages. I think it's a good idea. There is even more information available but this is probabl

Re: [PATCH 4/6] sfxge: add counter for Tx errors returned from if_transmit

2014-03-18 Thread Andrew Rybchenko
Gleb, On 03/18/2014 04:59 PM, Gleb Smirnoff wrote: Andrew, Boris, > > On Tue, Mar 18, 2014 at 01:58:40PM +0400, Andrew Rybchenko wrote: > A> sfxge: add counter for Tx errors returned from if_transmit > A> > A> Submitted-by: Boris Misenov > A> Sponsored by: Solarflare Communications, Inc.

Re: [PATCH 1/6] sfxge: fix mbuf leak if it does not fit in software queue

2014-03-18 Thread Gleb Smirnoff
On Wed, Mar 19, 2014 at 09:00:32AM +0400, Andrew Rybchenko wrote: A> Gleb, A> A> On 03/18/2014 04:46 PM, Gleb Smirnoff wrote: A> >Andrew, A> > A> > On Tue, Mar 18, 2014 at 01:11:15PM +0400, Andrew Rybchenko wrote: A> > A> A> > A> sfxge: fix mbuf leak if it does not fit in software queue A> > A

Re: [PATCH 1/6] sfxge: fix mbuf leak if it does not fit in software queue

2014-03-18 Thread Andrew Rybchenko
Gleb, On 03/18/2014 04:46 PM, Gleb Smirnoff wrote: Andrew, On Tue, Mar 18, 2014 at 01:11:15PM +0400, Andrew Rybchenko wrote: A> A> sfxge: fix mbuf leak if it does not fit in software queue A> A> mbuf should be owned by if_transmit function in any case. A> A> Submitted-by: Andrew Rybchenko

Re: [patch] [1/6] sfxge: fix mbuf leak if it does not fit in software queue

2014-03-18 Thread George Neville-Neil
On Mar 15, 2014, at 9:13 , Andrew Rybchenko wrote: > > <1-sfxge-leak.patch> Committed this morning. Best, George ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freeb

Re: socket receive buffer size & window updates

2014-03-18 Thread George Neville-Neil
On Mar 11, 2014, at 13:58 , Vijay Singh wrote: > The socket option handler currently doesn't prevent connecting or connected > sockets from changing their receive buffer sizes. In particular, I ran into > a an application that sets the receive buffer size lower than what it > originally was. >

Re: Include port number in "Listen queue overflow" messages

2014-03-18 Thread George Neville-Neil
On Mar 7, 2014, at 1:23 , hiren panchasara wrote: > I am thinking of committing following change that includes port number > in "Listen queue overflow" messages. > I like it. Best, George > New message would look something like: > sonewconn: pcb 0xf8001b155760: Listen queue overflow on p

Re: DCTCP for FreeBSD

2014-03-18 Thread George Neville-Neil
On Feb 19, 2014, at 4:18 , Eggert, Lars wrote: > Hi, > > Midori Kato has implemented Microsoft's/Stanford's Datacenter TCP (DCTCP) for > FreeBSD as part of her MS thesis with me. Find a patch attached. > Thanks! Any hints on how best to test this code? Best, George > Also note that we're

Re: [PATCH 1/6] sfxge: fix mbuf leak if it does not fit in software queue

2014-03-18 Thread George Neville-Neil
On Mar 18, 2014, at 7:44 , Adrian Chadd wrote: > Hi! > > Who's the solarflare driver maintainer? > > Ah, there isn't one. The closest is Ben Hutchings . > > I can commit these if no-one else is willing but I don't have any > solarflare hardware to test it on. > > I am taking care of this.

Re: [PATCH 2/6] sfxge: limit software Tx queue size

2014-03-18 Thread Gleb Smirnoff
Andrew, On Tue, Mar 18, 2014 at 01:55:01PM +0400, Andrew Rybchenko wrote: A> sfxge: limit software Tx queue size A> A> Previous implementation limits put queue size only (when Tx lock can't A> be acquired), A> but get queue may grow unboundedly which results in mbuf pools A> exhaustion and A>

Re: vlanXXX vs ifXX.YY notation

2014-03-18 Thread Adam McDougall
On 03/18/2014 01:42, Zeus Panchenko wrote: > hi, > > is there any advantage of using vlanXXX vs ifXX.YY notation? > > I mean > >> ifconfig em0 > vlan777: flags=8843 metric 0 mtu 1500 >ether 00:1b:b9:8b:ca:33 > ... >vlan: 777 parent interface: em0 > > vs > > em0.555: flags=8843

Re: [PATCH 4/6] sfxge: add counter for Tx errors returned from if_transmit

2014-03-18 Thread Gleb Smirnoff
Andrew, Boris, On Tue, Mar 18, 2014 at 01:58:40PM +0400, Andrew Rybchenko wrote: A> sfxge: add counter for Tx errors returned from if_transmit A> A> Submitted-by: Boris Misenov A> Sponsored by: Solarflare Communications, Inc. I'd suggest not to use atomic(9) increment there, since it lo

Re: [PATCH 3/6] sfxge: return error when packet is dropped because of link down

2014-03-18 Thread Gleb Smirnoff
On Tue, Mar 18, 2014 at 01:56:22PM +0400, Andrew Rybchenko wrote: A> sfxge: return error when packet is dropped because of link down A> A> Submitted-by: Boris Misenov A> Sponsored by: Solarflare Communications, Inc. Committed, thanks. -- Totus tuus, Glebius. ___

Re: [PATCH 1/6] sfxge: fix mbuf leak if it does not fit in software queue

2014-03-18 Thread Gleb Smirnoff
Andrew, On Tue, Mar 18, 2014 at 01:11:15PM +0400, Andrew Rybchenko wrote: A> A> sfxge: fix mbuf leak if it does not fit in software queue A> A> mbuf should be owned by if_transmit function in any case. A> A> Submitted-by: Andrew Rybchenko A> Sponsored by: Solarflare Communications, Inc.

Re: [PATCH 1/6] sfxge: fix mbuf leak if it does not fit in software queue

2014-03-18 Thread Adrian Chadd
Hi! Who's the solarflare driver maintainer? Ah, there isn't one. The closest is Ben Hutchings . I can commit these if no-one else is willing but I don't have any solarflare hardware to test it on. -a On 18 March 2014 02:11, Andrew Rybchenko wrote: > > sfxge: fix mbuf leak if it does not fit

Re: kern/183390: [ixgbe] 10gigabit networking problems

2014-03-18 Thread Johan Kooijman
Keep these two threads in mind, I believe it's the same issue: http://lists.freebsd.org/pipermail/freebsd-net/2014-February/037967.html http://lists.freebsd.org/pipermail/freebsd-net/2014-March/038061.html On Mon, Mar 17, 2014 at 11:42 PM, wrote: > Synopsis: [ixgbe] 10gigabit networking proble

[PATCH 6/6] sfxge: implement interface statistics shown by netstat

2014-03-18 Thread Andrew Rybchenko
sfxge: implement interface statistics shown by netstat netstat directly reads interface statistics collected in the ifnet structure members: if_ipackets, if_ierrors, if_iqdrops, if_opackets, if_oerrors, if_collisions. The if_oerrors counter should include both errors reported by hardware and erro

[PATCH 5/6] sfxge: access statistics buffers under port lock

2014-03-18 Thread Andrew Rybchenko
sfxge: access statistics buffers under port lock Allow access to statistics data not only from sysctl handlers. Submitted-by: Boris Misenov Sponsored by: Solarflare Communications, Inc. diff -r af2586a023d8 -r 7f58b1a5ea60 src/driver/freebsd/sfxge_port.c --- a/head/sys/dev/sfxge/sfxge_port

[PATCH 4/6] sfxge: add counter for Tx errors returned from if_transmit

2014-03-18 Thread Andrew Rybchenko
sfxge: add counter for Tx errors returned from if_transmit Submitted-by: Boris Misenov Sponsored by: Solarflare Communications, Inc. diff -r 53935db50f8a -r af2586a023d8 src/driver/freebsd/sfxge_tx.c --- a/head/sys/dev/sfxge/sfxge_tx.cMon Mar 10 11:37:12 2014 +0400 +++ b/head/sys/dev/sf

[PATCH 3/6] sfxge: return error when packet is dropped because of link down

2014-03-18 Thread Andrew Rybchenko
sfxge: return error when packet is dropped because of link down Submitted-by: Boris Misenov Sponsored by: Solarflare Communications, Inc. diff -r d292c9f51d36 -r 53935db50f8a src/driver/freebsd/sfxge_tx.c --- a/head/sys/dev/sfxge/sfxge_tx.cThu Mar 06 13:38:55 2014 + +++ b/head/sys/d

[PATCH 2/6] sfxge: limit software Tx queue size

2014-03-18 Thread Andrew Rybchenko
sfxge: limit software Tx queue size Previous implementation limits put queue size only (when Tx lock can't be acquired), but get queue may grow unboundedly which results in mbuf pools exhaustion and latency growth. Submitted-by: Andrew Rybchenko Sponsored by: Solarflare Communications, I

[PATCH 1/6] sfxge: fix mbuf leak if it does not fit in software queue

2014-03-18 Thread Andrew Rybchenko
sfxge: fix mbuf leak if it does not fit in software queue mbuf should be owned by if_transmit function in any case. Submitted-by: Andrew Rybchenko Sponsored by: Solarflare Communications, Inc. diff -r e2bc8f64f1b2 -r ff9f5d3dbafe src/driver/freebsd/sfxge_tx.c --- a/head/sys/dev/sfxge/sfxg