Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-02 Thread Andre Oppermann
On 02.11.2012 18:18, Luigi Rizzo wrote: On Fri, Nov 02, 2012 at 09:12:23AM -0700, Juli Mallett wrote: On Fri, Nov 2, 2012 at 5:54 AM, Andre Oppermann wrote: On 02.11.2012 13:38, Gleb Smirnoff wrote: #define M_SKIP_FIREWALL 0x4000 /* skip firewall processing */ This one should become a

Session MTU update patch only 9

2012-11-02 Thread Jason Wolfe
Hi, While attempting to fix a PMTUD bug in 8.3-RELEASE-p4 that appears to now be resolved by r234342, I also came across r238516. It appears this fix only made it into 9/STABLE though, does anyone know why it wasn't brought back to 8? It's a fairly easy port, but I just wanted to confirm there w

Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-02 Thread Luigi Rizzo
On Fri, Nov 02, 2012 at 09:12:23AM -0700, Juli Mallett wrote: > On Fri, Nov 2, 2012 at 5:54 AM, Andre Oppermann wrote: > > > On 02.11.2012 13:38, Gleb Smirnoff wrote: > > > >> #define M_SKIP_FIREWALL 0x4000 /* skip firewall processing */ > >> > > > > This one should become an M_PROTO overlay.

Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-02 Thread Juli Mallett
On Fri, Nov 2, 2012 at 5:54 AM, Andre Oppermann wrote: > On 02.11.2012 13:38, Gleb Smirnoff wrote: > >> #define M_SKIP_FIREWALL 0x4000 /* skip firewall processing */ >> > > This one should become an M_PROTO overlay. It is only relevant within > a protocol layer. No, like M_PROMISC it needs

Re: svn commit: r242473 - user/andre/tcp_workqueue/sys/dev/ixgbe

2012-11-02 Thread Andre Oppermann
On 02.11.2012 14:43, Andre Oppermann wrote: Author: andre Date: Fri Nov 2 13:43:17 2012 New Revision: 242473 URL: http://svn.freebsd.org/changeset/base/242473 Log: Merge ixgbe_tx_ctx_setup() and ixgbe_tso_setup() together into ixgbe_offload_setup() as they have a large overlap in packet

Panic in bpf.c catchpacket()

2012-11-02 Thread Guy Helmer
Still working this problem I've previously mentioned, and my working theory now is a race between catchpacket() and this code in bpfread(): /* * At this point, we know we have something in the hold slot. */ BPFD_UNLOCK(d); /* * Move data from ho

Re: splitting m_flags to pkthdr.flags + m_flags

2012-11-02 Thread Andre Oppermann
On 02.11.2012 13:38, Gleb Smirnoff wrote: Hello networkers, some (most) of m_flags bits are describing features that can be present on a packet only, not on a single mbuf. Since we are close to exhaustion of available bits, and many subsystems prefer to use one of M_PROTO bits instead of g

splitting m_flags to pkthdr.flags + m_flags

2012-11-02 Thread Gleb Smirnoff
Hello networkers, some (most) of m_flags bits are describing features that can be present on a packet only, not on a single mbuf. Since we are close to exhaustion of available bits, and many subsystems prefer to use one of M_PROTO bits instead of grabbing a flag, I propose to split m_flags to