Code review

2008-08-24 Thread M. Warner Losh
I did this a few years ago when trying to track down a problem with some realtek network chips that I was having problems with at Timing Solutions. I'd like to get this into the tree, since it was helpful then. Comments? Warner diff -ur src/sys/pci/if_rl.c newcard/src/sys/pci/if_rl.c --- src/sys

Re: Code review request

2008-08-24 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Roman Kurakin <[EMAIL PROTECTED]> writes: : M. Warner Losh wrote: : > I've been shepherding this patch in my p4 tree for a long time. It : > removes the obsolete support for other systems in if_spppsubr.c. Is : > there a reason I shouldn't commit this?

Re: [CFT/R] IPv4 source address selection

2008-08-24 Thread Bruce M. Simpson
Bjoern A. Zeeb wrote: Hi, I have a patch, that was inspired by work from Y!, to do porper IPv4 source address selection for unbound sockets (with multi-IP jails). Hi, This kinda overlaps with some other ideas I'd like to see go in. It looks good and if it's already been tested, it should pro

Re: Code review request

2008-08-24 Thread Roman Kurakin
M. Warner Losh wrote: I've been shepherding this patch in my p4 tree for a long time. It removes the obsolete support for other systems in if_spppsubr.c. Is there a reason I shouldn't commit this? It was there to ease the keeping code in sync with other systems. Please ask Joerg Wunsch befo

Re: Code review request

2008-08-24 Thread Bruce M. Simpson
M. Warner Losh wrote: I've been shepherding this patch in my p4 tree for a long time. It removes the obsolete support for other systems in if_spppsubr.c. Is there a reason I shouldn't commit this? Looks fine to me. ___ freebsd-net@freebsd.org mai

[CFT/R] IPv4 source address selection

2008-08-24 Thread Bjoern A. Zeeb
Hi, I have a patch, that was inspired by work from Y!, to do porper IPv4 source address selection for unbound sockets (with multi-IP jails). You can temporary find it here: http://people.freebsd.org/~bz/20080823-01-in_pcbladdr.diff People running my latest jail patches have been ``testing'' thi

Re: strange TCP issue on RELENG_7

2008-08-24 Thread Mike Tancsa
At 02:18 AM 8/24/2008, Julian Elischer wrote: ok so it might be related to the MRT code... I assume he only has one Routing table.. Yes, just one routing table Theoretically it shoudl work the same as before if N==1 but I can imagine a case where it didn't. especially if arp and interffaces

Code review request

2008-08-24 Thread M. Warner Losh
I've been shepherding this patch in my p4 tree for a long time. It removes the obsolete support for other systems in if_spppsubr.c. Is there a reason I shouldn't commit this? Warner Index: if_spppsubr.c === --- if_spppsubr.c (