Re: [PATCH] Remove -nostdinc in aicasm

2011-07-03 Thread Robert Millan
2011/7/3 Matthias Andree : > Note that there are GCC-version-specific directories for the more > intricate details such as stdarg.h and compiler-specific builtins -- you > don't get those with -I/usr/include either. I know. That's actually the problem I'm trying to solve ( not found). -- Robert

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Robert Millan
2011/7/3 Benjamin Kaduk : > %       builtin_define_with_int_value ("__FreeBSD__", FBSD_MAJOR);      \ > % +     builtin_define ("__FreeBSD_kernel__");                          \ > > Is there a reason to prefer just defining the symbol to also including the > major version number as is done for __Fr

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Robert Millan
2011/7/3 Alexander Kabaev : > I do not think this belongs in GCC at all. You should already have a > defined symbol to identify your OS and that should be used in cases > where it matters. If we wanted to identify the OS as a whole, we can currently do this with something like: "#if defined(__Fre

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Robert Millan
2011/7/3 Ed Maste : >> Alternatively, you should provide the symbol in >> similar way in which we provide __FreeBSD_version, through well-known >> header like sys/param.h and not pollute GCC. > > I suspect this is probably a reasonable alternative, but may mean software > will have to pick up an ad

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Robert Millan
2011/7/3 Alexander Kabaev : > GCC is on the way to be > pushed out into ports in FreeBSD and it will not the the only usable > compiler before long. Your proposal will force similar changes in > Clang, Path64 and PCC, , to be really universal which is not > practical. Would my proposal be more wel

[PATCH] PAGE_SIZE in libsbuf

2011-07-03 Thread Robert Millan
On arm, ia64, powerpc and sparc, Linux doesn't define a static PAGE_SIZE. It can only be obtained via sysconf(). In addition, GNU/Hurd doesn't define PAGE_SIZE at all. This patch improves portability of libsbuf to be built on those platforms. In case you'd like to know, Debian is using libsbuf

Re: [PATCH] PAGE_SIZE in libsbuf

2011-07-03 Thread Kostik Belousov
On Sun, Jul 03, 2011 at 01:47:38PM +0200, Robert Millan wrote: > On arm, ia64, powerpc and sparc, Linux doesn't define a static > PAGE_SIZE. It can only be obtained via sysconf(). In addition, > GNU/Hurd doesn't define PAGE_SIZE at all. > > This patch improves portability of libsbuf to be built

Re: [PATCH] PAGE_SIZE in libsbuf

2011-07-03 Thread Robert Millan
2011/7/3 Kostik Belousov : > I think the different workaround is already included in the latest > sbuf source. Please see > http://svnweb.freebsd.org/base/head/sys/kern/subr_sbuf.c?revision=222015&view=markup How does libsbuf react if the guess fails? Also note this codepath isn't tested in FreeB

Re: [PATCH] PAGE_SIZE in libsbuf

2011-07-03 Thread Kostik Belousov
On Sun, Jul 03, 2011 at 02:07:59PM +0200, Robert Millan wrote: > 2011/7/3 Kostik Belousov : > > I think the different workaround is already included in the latest > > sbuf source. Please see > > http://svnweb.freebsd.org/base/head/sys/kern/subr_sbuf.c?revision=222015&view=markup > > How does libsb

Re: [PATCH] Remove -nostdinc in aicasm

2011-07-03 Thread Robert Millan
2011/7/2 Robert Millan : > 2011/7/2 Benjamin Kaduk : >> There is a functional difference between '-nostdinc -I/usr/include -I.' even >> when the standard include search path is just /usr/include -- the standard >> include paths are always searched last (unless -nostdinc is given), even if >> they a

Re: [PATCH] PAGE_SIZE in libsbuf

2011-07-03 Thread Robert Millan
2011/7/3 Kostik Belousov : > Which runtime errors ? The constant is used to size the malloc > allocations. Use of the PAGE_SIZE is an attempt to do some optimization. > > I think it would work if you use e.g. 42 instead of PAGE_SIZE. Never mind then. Thanks for the info. -- Robert Millan __

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Alexander Kabaev
On Sat, 2 Jul 2011 20:05:12 -0700 Garrett Cooper wrote: > On Sat, Jul 2, 2011 at 7:08 PM, Ed Maste wrote: > > On Sat, Jul 02, 2011 at 07:37:24PM -0400, Alexander Kabaev wrote: > > > >> On Sat, 2 Jul 2011 17:41:03 +0200 > >> Robert Millan wrote: > >> > >> > My request is that FreeBSD also define

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Chris Rees
2011/7/3 Alexander Kabaev : > > __linux__ is exactly what __FreeBSD__ is and dies not identify kernel > but rather Linux as whole OS, whatever that might be these days. > > There does not appear to be an universal macro that identifies > environment as using Linux kernel regardless of the rest of c

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Alexander Kabaev
On Sun, 3 Jul 2011 12:41:44 +0200 Robert Millan wrote: > 2011/7/3 Alexander Kabaev : > > GCC is on the way to be > > pushed out into ports in FreeBSD and it will not the the only usable > > compiler before long. Your proposal will force similar changes in > > Clang, Path64 and PCC, , to be really

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Alexander Kabaev
On Sun, 3 Jul 2011 15:38:41 +0100 Chris Rees wrote: > 2011/7/3 Alexander Kabaev : > > > > __linux__ is exactly what __FreeBSD__ is and dies not identify > > kernel but rather Linux as whole OS, whatever that might be these > > days. > > > > There does not appear to be an universal macro that iden

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Chris Rees
On 3 July 2011 15:44, Alexander Kabaev wrote: > On Sun, 3 Jul 2011 15:38:41 +0100 > Chris Rees wrote: >> 2011/7/3 Alexander Kabaev : >> > >> > __linux__ is exactly what __FreeBSD__ is and dies not identify >> > kernel but rather Linux as whole OS, whatever that might be these >> > days. >> > >> >

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Robert Millan
2011/7/3 Alexander Kabaev : > __linux__ is exactly what __FreeBSD__ is and dies not identify kernel > but rather Linux as whole OS, whatever that might be these days. > > There does not appear to be an universal macro that identifies > environment as using Linux kernel regardless of the rest of com

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Robert Millan
2011/7/3 Alexander Kabaev : > Not really, unless you have way of sticking this definition into past > compiler releases. There is one way, but it's slow. It basically involves waiting for long enough that any past release of any compiler you care about includes the macros you need, before startin

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Robert Millan
2011/7/3 Robert Millan : > 2011/7/3 Alexander Kabaev : >> Not really, unless you have way of sticking this definition into past >> compiler releases. > > There is one way, but it's slow.  It basically involves waiting for > long enough that any past release of any compiler you care about > includes

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Julian Elischer
On 7/3/11 7:35 AM, Alexander Kabaev wrote: __linux__ is exactly what __FreeBSD__ is and dies not identify kernel but rather Linux as whole OS, whatever that might be these days. There does not appear to be an universal macro that identifies environment as using Linux kernel regardless of the res

Re: [PATCH] build config(8) on GNU systems

2011-07-03 Thread Ed Schouten
* Robert Millan , 20110702 16:56: > Index: usr.sbin/config/main.c > === > --- usr.sbin/config/main.c(revision 223721) > +++ usr.sbin/config/main.c(working copy) > @@ -591,7 +591,11 @@ > if ((dirp = opendir(p)) == NULL) >

Re: [PATCH] build config(8) on GNU systems

2011-07-03 Thread Ed Schouten
* Zhihao Yuan , 20110703 22:22: > Programmers always want to make things "cooler". Just leave the > ->d_namlen there :) Portability isn't achieved by adding #ifdefs, but by writing portable code. ;-) -- Ed Schouten WWW: http://80386.nl/ pgpbqUUDWhNbF.pgp Description: PGP signature

Re: [PATCH] build config(8) on GNU systems

2011-07-03 Thread Robert Millan
2011/7/3 Ed Schouten : > * Zhihao Yuan , 20110703 22:22: >> Programmers always want to make things "cooler". Just leave the >> ->d_namlen there :) > > Portability isn't achieved by adding #ifdefs, but by writing portable > code. ;-) I really don'

Re: [PATCH] build config(8) on GNU systems

2011-07-03 Thread Zhihao Yuan
Programmers always want to make things "cooler". Just leave the ->d_namlen there :) On Sun, Jul 3, 2011 at 2:49 PM, Ed Schouten wrote: > * Robert Millan , 20110702 16:56: >> Index: usr.sbin/config/main.c >> === >> --- usr.sbin/config

Re: [PATCH] build config(8) on GNU systems

2011-07-03 Thread Ed Schouten
Fixed in r223744. Thanks! -- Ed Schouten WWW: http://80386.nl/ pgpBp8MHciKH9.pgp Description: PGP signature

Re: [PATCH] __FreeBSD_kernel__

2011-07-03 Thread Robert Millan
2011/7/3 Mark Linimon : > On Sun, Jul 03, 2011 at 05:47:02PM +0200, Robert Millan wrote: >> isn't it enough if support is present in the FreeBSD >> version of these compilers (for production and development releases of >> FreeBSD), plus the latest release of the upstream version of each of >> those