Re: pfctl

2006-11-28 Thread Henning Brauer
* Earl Lapus <[EMAIL PROTECTED]> [2006-11-28 02:41]: > I read that realtime must always be convex. That explains the checking. > However, linkshare and upperlimit can be either concave or convex. correct > If linkshare(lssc_xx) can be concave then we should allow lssc_m1 to be > less than lssc_m2

Re: pfctl

2006-11-27 Thread Earl Lapus
(henning 17-Dec-02): (opts->lssc_m1 > 0 && opts->lssc_m2 == 0) || 1.24 (henning 17-Dec-02): (opts->ulsc_m1 > 0 && opts->ulsc_m2 == 0)) { almost 4 years, and nobody noticed ;( Index: pfctl_altq.c ===

Re: pfctl

2006-11-27 Thread Henning Brauer
2 == 0) || 1.24 (henning 17-Dec-02): (opts->ulsc_m1 > 0 && opts->ulsc_m2 == 0)) { almost 4 years, and nobody noticed ;( Index: pfctl_altq.c === RCS file: /cvs/src/sbin/pfctl/pfctl_altq.c,v retrieving revision 1.90 diff -u -p -r1.90 pfctl_a

Re: pfctl

2006-11-27 Thread Vasil Dimov
t;rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) { > warnx("m1 must be zero for convex curve: %s", pa->qname); > return (-1); > } > ... > > -OR- is there something between those lines that I'm missing. > > The piece of code that I&

pfctl

2006-11-27 Thread Earl Lapus
urn (-1); } ... -OR- is there something between those lines that I'm missing. The piece of code that I'm referring to is found in /usr/src/contrtib/pf/pfctl/pfctl_altq.c -- There are seven words in this sentence. ___ freebsd-hackers