Re: oops, here's the patch

1999-06-15 Thread Ville-Pertti Keinonen
dil...@apollo.backplane.com (Matthew Dillon) writes: > However, if the inside of the first conditional generates an error, the vp > may be vput twice. What I recommend is this for the last bit: That can't happen (the attributes are straight from VATTR_NULL along that path) - if it could

Re: oops, here's the patch

1999-06-14 Thread Matthew Dillon
Oh man that routine is complex! I'm looking at it closely and I think you are right, except I think you may have introduced a minor bug in fixing the other bug. Here is the code and the last bit of your modification for reference: if (vap->va_size != -1) {

oops, here's the patch

1999-06-14 Thread David E. Cross
*** nfs_serv.c Tue Jun 8 15:53:11 1999 --- /cs/crossd/nfs_serv.c Mon Jun 14 16:05:45 1999 *** *** 1343,1348 --- 1343,1349 fhandle_t *fhp; u_quad_t frev, tempsize; u_char cverf[NFSX_V3CREATEVERF]; + int eexistdebug=0; #ifndef nolint