Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-26 Thread Alexander Best
Jaakko Heinonen schrieb am 2010-03-26: > On 2010-03-05, Jaakko Heinonen wrote: > > I have updated the patch taking some of bde's comments into > > account. The > > new version also includes updates for namei(9) manual page. > Yet another update: > http://people.freebsd.org/~jh/patches/loo

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-26 Thread Jaakko Heinonen
On 2010-03-05, Jaakko Heinonen wrote: > I have updated the patch taking some of bde's comments into account. The > new version also includes updates for namei(9) manual page. Yet another update: http://people.freebsd.org/~jh/patches/lookup-root.4.diff I have committed the relookup() part

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-11 Thread Jaakko Heinonen
On 2010-03-11, Alexander Best wrote: > in sys/kern/vfs_syscalls.c:kern_rmdirat() there's still local code to check > for "." and "/" after applying your patch. isn't this all being done by > calling namei() now? Looking at it quickly I think that the "." case is handled by lookup() since r199137.

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-11 Thread Alexander Best
Jaakko Heinonen schrieb am 2010-03-11: > On 2010-03-10, Alexander Best wrote: > > could this panic have been triggered by the patch? > It doesn't look like it's caused by the patch. > > panic() at panic+0x15f > > _mtx_lock_flags() at _mtx_lock_flags+0xc5 > > fdesc_allocvp() at fdesc_allocvp+0xbf

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-11 Thread Jaakko Heinonen
On 2010-03-10, Alexander Best wrote: > could this panic have been triggered by the patch? It doesn't look like it's caused by the patch. > panic() at panic+0x15f > _mtx_lock_flags() at _mtx_lock_flags+0xc5 > fdesc_allocvp() at fdesc_allocvp+0xbf > fdesc_lookup() at fdesc_lookup+0x15c > > this wa

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-10 Thread Alexander Best
Jaakko Heinonen schrieb am 2010-03-05: > On 2010-02-28, Jaakko Heinonen wrote: > > > > http://people.freebsd.org/~jh/patches/lookup-root.diff > I have updated the patch taking some of bde's comments into account. > The > new version also includes updates for namei(9) manual page. could this pan

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-07 Thread Jaakko Heinonen
On 2010-03-06, Garrett Cooper wrote: > > > >        http://people.freebsd.org/~jh/patches/lookup-root.2.diff > > 1. EBUSY's new definition doesn't look correct for rename(2) given > POSIX's definition ( > http://www.opengroup.org/onlinepubs/009695399/functions/rename.html ): > > [EBUSY] > [CX

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-06 Thread Garrett Cooper
On Thu, Mar 4, 2010 at 9:57 PM, Jaakko Heinonen wrote: > On 2010-02-28, Jaakko Heinonen wrote: >> > >   http://people.freebsd.org/~jh/patches/lookup-root.diff > > I have updated the patch taking some of bde's comments into account. The > new version also includes updates for namei(9) manual page.

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-04 Thread Jaakko Heinonen
On 2010-02-28, Jaakko Heinonen wrote: > > > http://people.freebsd.org/~jh/patches/lookup-root.diff I have updated the patch taking some of bde's comments into account. The new version also includes updates for namei(9) manual page. The patch is attached to this mail and also found at:

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-01 Thread Nate Eldredge
On Sun, 28 Feb 2010, Garrett Cooper wrote: On Sun, Feb 28, 2010 at 5:11 PM, Alexander Best wrote: i have a small test app to check {rm|mk}dir()'s errnos with certain args like /, ., /proc and non-empty dirs. i'll submit it to this thread as soon as i also add testcases for syscalls like rename

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-03-01 Thread Gary Jennejohn
On Sun, 28 Feb 2010 18:26:05 -0800 Garrett Cooper wrote: > On Sun, Feb 28, 2010 at 5:11 PM, Alexander Best wrote: > > i have a small test app to check {rm|mk}dir()'s errnos with certain args > > like > > /, ., /proc and non-empty dirs. i'll submit it to this thread as soon as i > > also add tes

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-02-28 Thread Garrett Cooper
On Sun, Feb 28, 2010 at 5:11 PM, Alexander Best wrote: > i have a small test app to check {rm|mk}dir()'s errnos with certain args like > /, ., /proc and non-empty dirs. i'll submit it to this thread as soon as i > also add testcases for syscalls like rename(), unlink(), etc. > > most of the errno

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-02-28 Thread Alexander Best
i have a small test app to check {rm|mk}dir()'s errnos with certain args like /, ., /proc and non-empty dirs. i'll submit it to this thread as soon as i also add testcases for syscalls like rename(), unlink(), etc. most of the errno codes returned after applying your patch look correct. i wonder h

Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-02-28 Thread Alexander Best
Bruce Evans said that the doesn't like this comment you added in your patchset /* * Check for "" which is a way of talking about the root directory. * We can't provide a parent node for CREATE, DELETE and RENAME * operations. */ and would like to keep "

namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

2010-02-28 Thread Jaakko Heinonen
[Moving discussion to -hackers. This is not directly related to the original commit anymore.] On 2010-02-26, Bruce Evans wrote: > > http://people.freebsd.org/~jh/patches/lookup-root.diff > This is in relookup(). I think relookup() is only called from rename(), > so the failing case is unrea