Re: ip_reass() - possibly incorrect goto

2005-04-08 Thread Maxim Konovalov
On Thu, 24 Mar 2005, 04:46-0600, Mike Silbersack wrote: > > On Wed, 23 Mar 2005, Maxim Konovalov wrote: > > > On Tue, 22 Mar 2005, 12:08-0800, [EMAIL PROTECTED] wrote: > > > > > Hi hackers, I am looking at the ip_reass() routine. In case of the > > > 1st fragment we create the reassembly queue. Af

Re: ip_reass() - possibly incorrect goto

2005-03-24 Thread Mike Silbersack
On Wed, 23 Mar 2005, Maxim Konovalov wrote: On Tue, 22 Mar 2005, 12:08-0800, [EMAIL PROTECTED] wrote: Hi hackers, I am looking at the ip_reass() routine. In case of the 1st fragment we create the reassembly queue. After the queue has been inserted in the hash bucket, the if () code does a " goto in

Re: ip_reass() - possibly incorrect goto

2005-03-23 Thread Maxim Konovalov
On Tue, 22 Mar 2005, 12:08-0800, [EMAIL PROTECTED] wrote: > Hi hackers, I am looking at the ip_reass() routine. In case of the > 1st fragment we create the reassembly queue. After the queue has > been inserted in the hash bucket, the if () code does a " goto > inserted". Should this be changed to

ip_reass() - possibly incorrect goto

2005-03-22 Thread Vijay.Singh
Hi hackers, I am looking at the ip_reass() routine. In case of the 1st fragment we create the reassembly queue. After the queue has been inserted in the hash bucket, the if () code does a " goto inserted". Should this be changed to "goto done" instead? Any code that is executed for the 1st fragm