Re: investigation of Giant usage in kernel

2007-03-26 Thread Kris Kennaway
On Sun, Mar 04, 2007 at 06:55:50PM +0100, Ed Schouten wrote: > Hello, > > I took a grep on the kernel source and took a look to Giant usage as > well. I too have a question about locking in uipc_domain.c: > > The file has a mutex, dom_mtx, which protects the 'domain list lock', > which could be d

Re: investigation of Giant usage in kernel

2007-03-26 Thread Kris Kennaway
On Sun, Mar 04, 2007 at 03:11:36PM +0100, Divacky Roman wrote: > hi > > I looked at where Giant is held in the kernel and I found these interesting > things: > > 1) in fs/fifofs/fifo_vnops.c we lock Giant when calling sorecieve()/sosend() > this is a bandaid for fixing a race that doesnt have to

Re: investigation of Giant usage in kernel

2007-03-05 Thread Kris Kennaway
On Tue, Mar 06, 2007 at 12:15:56AM +, Robert Watson wrote: > On Sun, 4 Mar 2007, Divacky Roman wrote: > > >I looked at where Giant is held in the kernel and I found these > >interesting things: > > > >1) in fs/fifofs/fifo_vnops.c we lock Giant when calling > >sorecieve()/sosend() this is a b

Re: investigation of Giant usage in kernel

2007-03-05 Thread Robert Watson
On Sun, 4 Mar 2007, Divacky Roman wrote: I looked at where Giant is held in the kernel and I found these interesting things: 1) in fs/fifofs/fifo_vnops.c we lock Giant when calling sorecieve()/sosend() this is a bandaid for fixing a race that doesnt have to exist anymore. ie. it needs some t

Re: investigation of Giant usage in kernel

2007-03-04 Thread Ed Schouten
Hello, I took a grep on the kernel source and took a look to Giant usage as well. I too have a question about locking in uipc_domain.c: The file has a mutex, dom_mtx, which protects the 'domain list lock', which could be declared static by the way. The strange thing is that it isn't used to lock

investigation of Giant usage in kernel

2007-03-04 Thread Divacky Roman
hi I looked at where Giant is held in the kernel and I found these interesting things: 1) in fs/fifofs/fifo_vnops.c we lock Giant when calling sorecieve()/sosend() this is a bandaid for fixing a race that doesnt have to exist anymore. ie. it needs some testing and can be remvoed 2) in geom/geom