Re: change to ee.c

2008-12-01 Thread Eitan Adler
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alexander Leidinger wrote: > It _may_ be more easy to find out which version is in our source tree, > and make a diff between the original vendor version and what we have. > Depending on the amount of changes there, this is faster than to real > all t

Re: change to ee.c

2008-12-01 Thread Alexander Leidinger
Quoting Bruce Cran <[EMAIL PROTECTED]> (from Sun, 30 Nov 2008 10:31:56 -0800): On Sun, 30 Nov 2008 09:12:26 -0500 Eitan Adler <[EMAIL PROTECTED]> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruce Cran wrote: > The version of ee in FreeBSD is fairly old: the latest from > http://maho

Re: change to ee.c

2008-12-01 Thread Dag-Erling Smørgrav
Eitan Adler <[EMAIL PROTECTED]> writes: > Xin LI <[EMAIL PROTECTED]> writes: > > Tanks for interested in this but I'm afraid that your patch is > > incorrect. mkstemp returns a file descriptor rather than a string > > pointer, therefore, the subsequent open() would have undefined > > behavior. It

Re: change to ee.c

2008-12-01 Thread Dag-Erling Smørgrav
Bruce Cran <[EMAIL PROTECTED]> writes: > The version of ee in FreeBSD is fairly old: the latest from > http://mahon.cwx.net/ is 1.4.6. Even so, the latest version still > generates lots of warnings from gcc because the developer used NULL > instead of '\0' (i.e the NULL constant instead of the NUL

Re: change to ee.c

2008-11-30 Thread Tim Kientzle
Eitan Adler wrote: Xin LI wrote: Tanks for interested in this but I'm afraid that your patch is incorrect. mkstemp returns a file descriptor rather than a string pointer, therefore, the subsequent open() would have undefined behavior. It looks like that we actually want fd = mkstemp() here.

Re: change to ee.c

2008-11-30 Thread Bruce Cran
On Sun, 30 Nov 2008 09:12:26 -0500 Eitan Adler <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Bruce Cran wrote: > > > The version of ee in FreeBSD is fairly old: the latest from > > http://mahon.cwx.net/ is 1.4.6. > How difficult would it be to bring it up to d

Re: change to ee.c

2008-11-30 Thread Eitan Adler
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruce Cran wrote: > The version of ee in FreeBSD is fairly old: the latest from > http://mahon.cwx.net/ is 1.4.6. How difficult would it be to bring it up to date? How come it has not been updated so far? - -- Eitan Adler GNU Key fingerptrint: 2E13

Re: change to ee.c

2008-11-30 Thread Bruce Cran
On Sat, 29 Nov 2008 23:21:48 -0500 Eitan Adler <[EMAIL PROTECTED]> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Xin LI wrote: > > Hi, Eitan, > > > Tanks for interested in this but I'm afraid that your patch is > > incorrect. mkstemp returns a file descriptor rather than a string

Re: change to ee.c

2008-11-29 Thread Eitan Adler
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Xin LI wrote: > Hi, Eitan, > Tanks for interested in this but I'm afraid that your patch is > incorrect. mkstemp returns a file descriptor rather than a string > pointer, therefore, the subsequent open() would have undefined behavior. > It looks lik

Re: change to ee.c

2008-11-29 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Eitan, Eitan Adler wrote: > I changed this pursuant to a warning I got from gcc. > according to the man page "This avoids the race between testing for a > file's existence and opening it for use." > > Could someone on this list please tell m

change to ee.c

2008-11-29 Thread Eitan Adler
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I changed this pursuant to a warning I got from gcc. according to the man page "This avoids the race between testing for a file's existence and opening it for use." Could someone on this list please tell me a) If mkstemp is supposed to be used in