Re: WEP keys for an driver

2000-10-09 Thread Doug Ambrisko
Brooks Davis writes: | On Mon, Oct 09, 2000 at 11:42:32AM -0700, Dave Cornejo wrote: | > Some comments on your code: | > - WEP keysare variable length from 5-13 bytes, you should just check for | > >=5 & <=13 (it seems odd, but I have seen networks that use the odd | > sizes). | | Since all the w

Re: WEP keys for an driver

2000-10-09 Thread Doug Ambrisko
Dave Cornejo writes: | It doesn't matter to me which version gets used - I just need the | capability to set the WEP keys. | | Some comments on your code: | - WEP keysare variable length from 5-13 bytes, you should just check for | >=5 & <=13 (it seems odd, but I have seen networks that use the o

Re: WEP keys for an driver

2000-10-09 Thread Brooks Davis
On Mon, Oct 09, 2000 at 11:42:32AM -0700, Dave Cornejo wrote: > Some comments on your code: > - WEP keysare variable length from 5-13 bytes, you should just check for > >=5 & <=13 (it seems odd, but I have seen networks that use the odd > sizes). Since all the windows drivers I've looked at only

Re: WEP keys for an driver

2000-10-09 Thread Dave Cornejo
It doesn't matter to me which version gets used - I just need the capability to set the WEP keys. Some comments on your code: - WEP keysare variable length from 5-13 bytes, you should just check for >=5 & <=13 (it seems odd, but I have seen networks that use the odd sizes). - In an_setkeys() you

Re: WEP keys for an driver

2000-10-09 Thread Doug Ambrisko
Dave Cornejo writes: | my apologies if i am not following the correct procedures here... | | I have submitted a patch in PR kern/21843 which adds WEP key support | to the an driver. This is my first attempt at messing with driver | code so any constructive criticism is appreciated. | | I have t

WEP keys for an driver

2000-10-09 Thread Dave Cornejo
my apologies if i am not following the correct procedures here... I have submitted a patch in PR kern/21843 which adds WEP key support to the an driver. This is my first attempt at messing with driver code so any constructive criticism is appreciated. I have tested the patch with the hardware a