Re: Some thoughts on if_ioctl()

2001-10-10 Thread Yar Tikhiy
On Mon, Oct 08, 2001 at 02:53:32PM -0400, Garrett Wollman wrote: > < said: > > > Second, let's look at the handling of SIOCADDMULTI/SIOCDELMULTI. > > There is code obviously taken from if_loop.c and used in some > > drivers, which tries to do something with the third argument "data" > > of the if

Some thoughts on if_ioctl()

2001-10-08 Thread Garrett Wollman
< said: > Second, let's look at the handling of SIOCADDMULTI/SIOCDELMULTI. > There is code obviously taken from if_loop.c and used in some > drivers, which tries to do something with the third argument "data" > of the if_ioctl() driver method if "data" isn't NULL. The historic implementation pas

Re: Some thoughts on if_ioctl()

2001-10-08 Thread Leo Bicknell
On Mon, Oct 08, 2001 at 09:03:54AM -0600, Warner Losh wrote: > Actaully, it should return ENOTTY rather than EINVAL. ENOTTY means > that the ioctl isn't understood. I've had to fix several drivers at > work that didn't follow this convention due to ignorance on the part > of the driver writer.

Re: Some thoughts on if_ioctl()

2001-10-08 Thread Warner Losh
In message <[EMAIL PROTECTED]> Yar Tikhiy writes: : First, the current implementation of the utility function : ether_ioctl(), which can do good job common to ethernet drivers, : won't indicate the situation when an ioctl command is unsupported : by it. It will return 0 in this case. Wouldn't it b

Some thoughts on if_ioctl()

2001-10-08 Thread Yar Tikhiy
Hi there, I'd like to discuss the following issues prior to modifying the kernel. First, the current implementation of the utility function ether_ioctl(), which can do good job common to ethernet drivers, won't indicate the situation when an ioctl command is unsupported by it. It will return 0 i