Re: Request for review: vnconfig.c

1999-08-27 Thread Oliver Fromme
Ben Smithurst wrote in list.freebsd-hackers: > Mark J. Taylor wrote: > > + dev = malloc(strlen(vnp->dev)+6); > > + (void)sprintf(dev, "/dev/%s", vnp->dev); > > You should be checking that malloc() doesn't return NULL, before trying > to write into the allocated sp

Re: Request for review: vnconfig.c

1999-08-27 Thread Oliver Fromme
Ben Smithurst wrote in list.freebsd-hackers: > Mark J. Taylor wrote: > > + dev = malloc(strlen(vnp->dev)+6); > > + (void)sprintf(dev, "/dev/%s", vnp->dev); > > You should be checking that malloc() doesn't return NULL, before trying > to write into the allocated s

Re: Request for review: vnconfig.c

1999-08-26 Thread Ben Smithurst
Mark J. Taylor wrote: > + dev = malloc(strlen(vnp->dev)+6); > + (void)sprintf(dev, "/dev/%s", vnp->dev); You should be checking that malloc() doesn't return NULL, before trying to write into the allocated space. -- Ben Smithurst| PGP: 0x99392F7D b...@scie

Re: Request for review: vnconfig.c

1999-08-26 Thread Ben Smithurst
Mark J. Taylor wrote: > + dev = malloc(strlen(vnp->dev)+6); > + (void)sprintf(dev, "/dev/%s", vnp->dev); You should be checking that malloc() doesn't return NULL, before trying to write into the allocated space. -- Ben Smithurst| PGP: 0x99392F7D [EMAIL P

Re: Request for review: vnconfig.c

1999-08-26 Thread Matthew Dillon
Looks good! -Matt Matthew Dillon :(Since this will be one of my first commits, I'd like to pass it by :as many people as possible.) : : :This patch makes "vnconfig" like "

Re: Request for review: vnconfig.c

1999-08-26 Thread Matthew Dillon
Looks good! -Matt Matthew Dillon <[EMAIL PROTECTED]> :(Since this will be one of my first commits, I'd like to pass it by :as many people as possible.) : : :This patch mak