Re: Enhancing cdboot [patch for review]

2008-12-11 Thread Bruce M. Simpson
This sounds and looks cool, diff looks OK (haven't applied), Luigi's comments seem well thought out and expressed. cheers BMS ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send an

Re: Enhancing cdboot [patch for review]

2008-12-11 Thread Jonathan McKeown
On Thursday 11 December 2008 14:42:46 Giorgos Keramidas wrote: > On Thu, 11 Dec 2008 10:52:49 +0200, Jonathan McKeown <[EMAIL PROTECTED]> wrote: > >> cdboot runs long after the prompt for BIOS setup. I don't think we > >> can modify cdboot to add serial console support to systems whose BIOS > >>

Re: Enhancing cdboot [patch for review]

2008-12-11 Thread Giorgos Keramidas
On Thu, 11 Dec 2008 10:52:49 +0200, Jonathan McKeown <[EMAIL PROTECTED]> wrote: >> cdboot runs long after the prompt for BIOS setup. I don't think we >> can modify cdboot to add serial console support to systems whose BIOS >> setup doesn't support it. > > Sorry, of course you're right: I'm talking

Re: Enhancing cdboot [patch for review]

2008-12-11 Thread Jonathan McKeown
On Thursday 11 December 2008 10:45:41 Giorgos Keramidas wrote: > On Thu, 11 Dec 2008 08:37:26 +0200, Jonathan McKeown <[EMAIL PROTECTED]> wrote: > > While you're enhancing cdboot anyway, can I ask how complicated it > > would be to make cdboot serial-console capable? (I'm not a C > > programmer, I

Re: Enhancing cdboot [patch for review]

2008-12-11 Thread Giorgos Keramidas
On Thu, 11 Dec 2008 08:37:26 +0200, Jonathan McKeown <[EMAIL PROTECTED]> wrote: > While you're enhancing cdboot anyway, can I ask how complicated it > would be to make cdboot serial-console capable? (I'm not a C > programmer, I'm a sysadmin - but I'd be prepared to try and look at > this myself if

Re: Enhancing cdboot [patch for review]

2008-12-10 Thread Jonathan McKeown
While you're enhancing cdboot anyway, can I ask how complicated it would be to make cdboot serial-console capable? (I'm not a C programmer, I'm a sysadmin - but I'd be prepared to try and look at this myself if no-one else is interested). As it stands, the only way I've found to do a serial-con

Re: Enhancing cdboot [patch for review]

2008-12-10 Thread John Baldwin
On Monday 08 December 2008 06:51:19 pm Luigi Rizzo wrote: > On Mon, Dec 08, 2008 at 02:40:41PM -0800, Maxim Sobolev wrote: > > Hi, > > > > Below please find patch that enhances cdboot with two compile-time options: > ... > > Any comments/suggestions are appreciated. If there are no objections I >

Re: Enhancing cdboot [patch for review]

2008-12-08 Thread Maxim Sobolev
Luigi Rizzo wrote: On Mon, Dec 08, 2008 at 04:29:04PM -0800, Maxim Sobolev wrote: Luigi Rizzo wrote: ... 4. another nitpick -- the value you pass in %si to the MBR does not seem to point to anything useful. As discussed about boot0.S and the followup in the mailing lists, there seems to be

Re: Enhancing cdboot [patch for review]

2008-12-08 Thread Luigi Rizzo
On Mon, Dec 08, 2008 at 04:29:04PM -0800, Maxim Sobolev wrote: > Luigi Rizzo wrote: ... > >4. another nitpick -- the value you pass in %si to the MBR does not > > seem to point to anything useful. As discussed about boot0.S and > > the followup in the mailing lists, there seems to be no standar

Re: Enhancing cdboot [patch for review]

2008-12-08 Thread Giorgos Keramidas
On Mon, 08 Dec 2008 16:29:04 -0800, Maxim Sobolev <[EMAIL PROTECTED]> wrote: > Luigi Rizzo wrote: >> On Mon, Dec 08, 2008 at 02:40:41PM -0800, Maxim Sobolev wrote: >>> Hi, >>> Below please find patch that enhances cdboot with two compile-time options: >> ... >>> Any comments/suggestions are appreci

Re: Enhancing cdboot [patch for review]

2008-12-08 Thread Maxim Sobolev
Luigi Rizzo wrote: On Mon, Dec 08, 2008 at 02:40:41PM -0800, Maxim Sobolev wrote: Hi, Below please find patch that enhances cdboot with two compile-time options: ... Any comments/suggestions are appreciated. If there are no objections I would like to commit the change. The long-term goal is t

Re: Enhancing cdboot [patch for review]

2008-12-08 Thread Luigi Rizzo
On Mon, Dec 08, 2008 at 02:40:41PM -0800, Maxim Sobolev wrote: > Hi, > > Below please find patch that enhances cdboot with two compile-time options: ... > Any comments/suggestions are appreciated. If there are no objections I > would like to commit the change. The long-term goal is to make > CDBOO