Re: [PATCH] PAGE_SIZE in libsbuf

2011-07-03 Thread Robert Millan
2011/7/3 Kostik Belousov : > Which runtime errors ? The constant is used to size the malloc > allocations. Use of the PAGE_SIZE is an attempt to do some optimization. > > I think it would work if you use e.g. 42 instead of PAGE_SIZE. Never mind then. Thanks for the info. -- Robert Millan __

Re: [PATCH] PAGE_SIZE in libsbuf

2011-07-03 Thread Kostik Belousov
On Sun, Jul 03, 2011 at 02:07:59PM +0200, Robert Millan wrote: > 2011/7/3 Kostik Belousov : > > I think the different workaround is already included in the latest > > sbuf source. Please see > > http://svnweb.freebsd.org/base/head/sys/kern/subr_sbuf.c?revision=222015&view=markup > > How does libsb

Re: [PATCH] PAGE_SIZE in libsbuf

2011-07-03 Thread Robert Millan
2011/7/3 Kostik Belousov : > I think the different workaround is already included in the latest > sbuf source. Please see > http://svnweb.freebsd.org/base/head/sys/kern/subr_sbuf.c?revision=222015&view=markup How does libsbuf react if the guess fails? Also note this codepath isn't tested in FreeB

Re: [PATCH] PAGE_SIZE in libsbuf

2011-07-03 Thread Kostik Belousov
On Sun, Jul 03, 2011 at 01:47:38PM +0200, Robert Millan wrote: > On arm, ia64, powerpc and sparc, Linux doesn't define a static > PAGE_SIZE. It can only be obtained via sysconf(). In addition, > GNU/Hurd doesn't define PAGE_SIZE at all. > > This patch improves portability of libsbuf to be built