Re: Giant free GEOM/CAM XPT

2010-07-23 Thread Jerry Toung
On Thu, Jul 22, 2010 at 10:47 PM, Alexander Motin wrote: > > Giant locked there only if DISKFLAG_NEEDSGIANT flag is set, which da > driver is not doing. > > > Alexander, my mistake. I am working on 2 branches at the moment 6.3 and 8.0. I got them all mixed up while going through my trees. 8.0 scs

Re: Giant free GEOM/CAM XPT

2010-07-22 Thread Alexander Motin
Jerry Toung wrote: > Hello List, > while going through the xpt code (8.0 RELEASE), it seems to me that some > gains can be had > in src/sys/geom/geom_disk.c where dp->d_strategy(bp2) is surrounded by Giant > lock. Especially in the case > where one has 2+ controllers on the system with /dev/daXX at

Giant free GEOM/CAM XPT

2010-07-22 Thread Jerry Toung
Hello List, while going through the xpt code (8.0 RELEASE), it seems to me that some gains can be had in src/sys/geom/geom_disk.c where dp->d_strategy(bp2) is surrounded by Giant lock. Especially in the case where one has 2+ controllers on the system with /dev/daXX attached to them during heavy I/O