Re: Commit schedule for bandwidth delay product pipeline limitingfor TCP

2002-08-17 Thread Matthew Dillon
:Comments below. Consider them only semi-informed. :) : :> +save_ticks = ticks; :> +if ((u_int)(save_ticks - tp->t_bw_rtttime) < 1) :> +return; : :If tp->t_bw_rtttime is greater than save_ticks, the unsigned compare will :fail. Can this ever happen (say with the "tick count

Re: Commit schedule for bandwidth delay product pipeline limitingfor TCP

2002-08-17 Thread Nate Lawson
Comments below. Consider them only semi-informed. :) On Fri, 16 Aug 2002, Matthew Dillon wrote: > +void > +tcp_xmit_bandwidth_limit(struct tcpcb *tp, tcp_seq ack_seq) > +{ > + u_long bw; > + u_long bwnd; > + int save_ticks; > + > + /* > + * If inflight_enable is disabled in

Re: Commit schedule for bandwidth delay product pipeline limitingfor TCP

2002-08-16 Thread Mike Silbersack
On Fri, 16 Aug 2002, Matthew Dillon wrote: > Since this code must be enabled via a sysctl I feel it is safe to > commit it to -current. I also intend to MFC it to -stable prior > to the freeze (MFC after: 1 week). I believe that we can eventually > enable the sysctl by default.