Re: Code review request: cdcontrol status label additon

2009-01-28 Thread Giorgos Keramidas
On Wed, 28 Jan 2009 10:19:00 -0700 (MST), "M. Warner Losh" wrote: > : lseek(3,0x8000,SEEK_SET) = 32768 (0x8000) > : read(3,0xbfbfe3a3,2048) ERR#5 'Input/output error' > > OK. That's definitely not page aligned. Slightly modified to force the alig

Re: Code review request: cdcontrol status label additon

2009-01-28 Thread M. Warner Losh
In message: <87d4e7e4y0@kobe.laptop> Giorgos Keramidas writes: : On Wed, 28 Jan 2009 18:29:10 +0200, Giorgos Keramidas wrote: : > On Wed, 28 Jan 2009 09:20:46 -0700 (MST), "M. Warner Losh" wrote: : >> Not going to look at glabel for this. I lifted the code from glable, : >> bu

Re: Code review request: cdcontrol status label additon

2009-01-28 Thread Giorgos Keramidas
On Wed, 28 Jan 2009 18:29:10 +0200, Giorgos Keramidas wrote: > On Wed, 28 Jan 2009 09:20:46 -0700 (MST), "M. Warner Losh" > wrote: >> Not going to look at glabel for this. I lifted the code from glable, >> but must have done it badly. I'll grab a core 10 cd and see what's up. > > It may not b

Re: Code review request: cdcontrol status label additon

2009-01-28 Thread M. Warner Losh
In message: <87mydbiecp@kobe.laptop> Giorgos Keramidas writes: : On Wed, 28 Jan 2009 09:20:46 -0700 (MST), "M. Warner Losh" wrote: : > Not going to look at glabel for this. I lifted the code from glable, : > but must have done it badly. I'll grab a core 10 cd and see what's up.

Re: Code review request: cdcontrol status label additon

2009-01-28 Thread Giorgos Keramidas
On Wed, 28 Jan 2009 09:20:46 -0700 (MST), "M. Warner Losh" wrote: > Not going to look at glabel for this. I lifted the code from glable, > but must have done it badly. I'll grab a core 10 cd and see what's up. It may not be Fedora specific. I just happened to have it handy... Sorry for creat

Re: Code review request: cdcontrol status label additon

2009-01-28 Thread M. Warner Losh
In message: <87k58f7npu@kobe.laptop> Giorgos Keramidas writes: : On Wed, 28 Jan 2009 02:09:50 -0700 (MST), "M. Warner Losh" wrote: : > Please find enclosed patches to enable printing of the ISO-9660 Volume : > label, if present, for a CD. I've connected this to the 'status : > l

Re: Code review request: cdcontrol status label additon

2009-01-28 Thread Giorgos Keramidas
On Wed, 28 Jan 2009 02:09:50 -0700 (MST), "M. Warner Losh" wrote: > Please find enclosed patches to enable printing of the ISO-9660 Volume > label, if present, for a CD. I've connected this to the 'status > label' command. Please comment. The style looks ok, but this didn't work for a Fedora C

Code review request: cdcontrol status label additon

2009-01-28 Thread M. Warner Losh
Please find enclosed patches to enable printing of the ISO-9660 Volume label, if present, for a CD. I've connected this to the 'status label' command. Please comment. Warner Index: cdcontrol.1 === --- cdcontrol.1 (revision 187760) +