Re: [PATCH] basic modelines for contrib/nvi

2004-07-25 Thread Nicolas Rachinsky
* José de Paula <[EMAIL PROTECTED]> [2004-07-25 18:03 -0300]: > On Mon, 19 Jul 2004 15:15:04 +0200, Jilles Tjoelker <[EMAIL PROTECTED]> wrote: > > > > > There are some options which can pose a security risk, including but not > > limited to cdpath, tempdir, path and shell. You should make a list

Re: [PATCH] basic modelines for contrib/nvi

2004-07-25 Thread José de Paula
On Mon, 19 Jul 2004 15:15:04 +0200, Jilles Tjoelker <[EMAIL PROTECTED]> wrote: > > There are some options which can pose a security risk, including but not > limited to cdpath, tempdir, path and shell. You should make a list of > "safe" options and only allow those in modelines. Thanks for the f

Re: [PATCH] basic modelines for contrib/nvi

2004-07-20 Thread Jilles Tjoelker
On Sun, Jul 18, 2004 at 06:46:34PM -0300, José de Paula wrote: > > On 2004-07-14 23:51, Jos? de Paula <[EMAIL PROTECTED]> wrote: > > > I hacked together this little patch to contrib/nvi to make it support > > > simple modelines. [snip] > So, what do you think about it, overall? This patch recogniz

Re: [PATCH] basic modelines for contrib/nvi

2004-07-18 Thread José de Paula
On Sun, 18 Jul 2004 16:55:41 +0300, Giorgos Keramidas <[EMAIL PROTECTED]> wrote: > On 2004-07-14 23:51, Jos? de Paula <[EMAIL PROTECTED]> wrote: > > I hacked together this little patch to contrib/nvi to make it support > > simple modelines. [snip] > > > + > > + if (O_ISSET(sp, O_MODELINE)) { >

Re: [PATCH] basic modelines for contrib/nvi

2004-07-18 Thread Giorgos Keramidas
On 2004-07-14 23:51, Jos? de Paula <[EMAIL PROTECTED]> wrote: > I hacked together this little patch to contrib/nvi to make it support > simple modelines. [snip] > + > + if (O_ISSET(sp, O_MODELINE)) { > + cmd = get_modeline(sp); > + if (cmd != NULL) > +

[PATCH] basic modelines for contrib/nvi

2004-07-14 Thread José de Paula
I hacked together this little patch to contrib/nvi to make it support simple modelines. The original author of nvi (Keith Bostic) says in the sources that modelines are not to be implemented because of security concerns, but I believe that implementing them after vim's style (i.e., only allowing ar