Re: [PATCH] Fix typos in bsd.port.mk and minor logic improvements

2010-07-13 Thread Garrett Cooper
On Tue, Jul 13, 2010 at 2:35 PM, b. f. wrote: >>So I'm taking it that the only change of benefit is the attached patch. > > While you are there, you might also: > > line 150: s/supercede/supersede/ > line 764: s/dependancies/dependencies/ > line 2982: s/everthing/everything/ > line 6142: s/servica

Re: [PATCH] Fix typos in bsd.port.mk and minor logic improvements

2010-07-13 Thread b. f.
>So I'm taking it that the only change of benefit is the attached patch. While you are there, you might also: line 150: s/supercede/supersede/ line 764: s/dependancies/dependencies/ line 2982: s/everthing/everything/ line 6142: s/servicable/serviceable/ b. ___

Re: [PATCH] Fix typos in bsd.port.mk and minor logic improvements

2010-07-13 Thread Garrett Cooper
On Mon, Jul 12, 2010 at 12:09 PM, Doug Barton wrote: > On 07/09/10 08:11, Garrett Cooper wrote: >> -# UNAUTHORISED CHANGES WILL BE UNCONDITIONALLY REVERTED! >> +# UNAUTHORIZED CHANGES WILL BE UNCONDITIONALLY REVERTED! > > Couple of comments. The above is not a typo, that's the British > spelling.

Re: [PATCH] Fix typos in bsd.port.mk and minor logic improvements

2010-07-13 Thread Sunpoet Hsieh
On Tue, Jul 13, 2010 at 3:02 PM, wrote: > Doug Barton wrote: >> > -# UNAUTHORISED CHANGES WILL BE UNCONDITIONALLY REVERTED! >> > +# UNAUTHORIZED CHANGES WILL BE UNCONDITIONALLY REVERTED! >> ... The above is not a typo, that's the British spelling. >> ... (Arguably it adds character to the projec

Re: [PATCH] Fix typos in bsd.port.mk and minor logic improvements

2010-07-13 Thread perryh
Doug Barton wrote: > > -# UNAUTHORISED CHANGES WILL BE UNCONDITIONALLY REVERTED! > > +# UNAUTHORIZED CHANGES WILL BE UNCONDITIONALLY REVERTED! > ... The above is not a typo, that's the British spelling. > ... (Arguably it adds character to the project.) :) Er, this example just changes one charac

Re: [PATCH] Fix typos in bsd.port.mk and minor logic improvements

2010-07-12 Thread Doug Barton
On 07/09/10 08:11, Garrett Cooper wrote: > -# UNAUTHORISED CHANGES WILL BE UNCONDITIONALLY REVERTED! > +# UNAUTHORIZED CHANGES WILL BE UNCONDITIONALLY REVERTED! Couple of comments. The above is not a typo, that's the British spelling. We generally don't change those. (Arguably it adds character to

[PATCH] Fix typos in bsd.port.mk and minor logic improvements

2010-07-12 Thread Garrett Cooper
This is a change I made locally that I figured would be helpful because it: a. Fixes typos. b. Improves branch flow in a few spots. c. Doesn't assume that all strings that come back from pkg_install are empty (this is what's assumed today). Thanks, -Garrett --- /usr/ports/Mk/bsd.port.m