Re: shmmax tops out at 2G?

2009-02-23 Thread Christian Peron
On Mon, Feb 23, 2009 at 11:58:09AM -0800, Garrett Cooper wrote: [..] > > Why isn't the field an unsigned int / size_t? I don't see much value > in having the size be signed... No idea :) This code long predates me. ___ freebsd-hackers@freebsd.or

Re: shmmax tops out at 2G?

2009-02-23 Thread Christian Peron
This issue has come up a number of times. I was looking into fixing this but I just have not had the time. The basic issue is our shmid_ds structure: struct shmid_ds { struct ipc_perm shm_perm; /* operation permission structure */ int shm_segsz; /* size of s

Re: write-only variables in src/sys/ - possible bugs

2009-02-04 Thread Christian Peron
On Wed, Feb 04, 2009 at 03:54:41PM +0100, Christoph Mallon wrote: [..] > > Yes, function arguments are considered being read. The problem is > different here: mtod() should be a macro, but the macro declaration was > missing (*cough* hacked build process *cough*). So the parser tried to > parse

Re: write-only variables in src/sys/ - possible bugs

2009-02-03 Thread Christian Peron
I started following up on this and ran into an issue for these: sys/net/bpf_buffer.c:133: warning: variable 'dst' is never read sys/net/bpf_buffer.c:134: warning: variable 'count' is never read sys/net/bpf_buffer.c:142: warning: variable 'dst' is never read /* * Scatter-gather data copy from an