Re: crontab Patches

2008-04-02 Thread Giorgos Keramidas
On Wed, 2 Apr 2008 15:35:02 -0400, Steven Kreuzer <[EMAIL PROTECTED]> wrote: > I wrote two patches for crontab.c that I was wondering if someone would > take a look at. > > The first one zero out pw_passwd in crontab, just to be paranoid side. > http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/122070

Re: pfind() and the proc structure

2008-04-02 Thread Giorgos Keramidas
On Wed, 2 Apr 2008 10:59:26 -0700, "Rao, Nikhil" <[EMAIL PROTECTED]> wrote: > Thanks for all your replies, > > the all_proc lock is held in pfind(..) at the point PROC_LOCK(p) is > obtained. In the kern_wait(..) code below, the allproc_lock is acquired > before removing the proc from the list of al

crontab Patches

2008-04-02 Thread Steven Kreuzer
I wrote two patches for crontab.c that I was wondering if someone would take a look at. The first one zero out pw_passwd in crontab, just to be paranoid side. http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/122070 The second replaces sprintf with snprintf http://www.freebsd.org/cgi/query-pr.cgi?pr

RE: pfind() and the proc structure

2008-04-02 Thread Rao, Nikhil
Thanks for all your replies, the all_proc lock is held in pfind(..) at the point PROC_LOCK(p) is obtained. In the kern_wait(..) code below, the allproc_lock is acquired before removing the proc from the list of all procs. The PROC_LOCK is then acquired before continuing. Since the thread that ca

Re: Regression tests for usr.sbin/zic and lib/libc/stdtime

2008-04-02 Thread Andrew Pantyukhin
On Wed, Apr 02, 2008 at 09:57:46AM -0400, Steven Kreuzer wrote: > - (void) sprintf(fullname, "%s/%s", directory, name); > + (void) snprintf(fullname, sizeof(filename), "%s/%s", directory, name); Has a typo crawled in? ___

Re: Regression tests for usr.sbin/zic and lib/libc/stdtime

2008-04-02 Thread Steven Kreuzer
On Wed, Apr 02, 2008 at 06:27:25PM +0400, Andrew Pantyukhin wrote: > On Wed, Apr 02, 2008 at 09:57:46AM -0400, Steven Kreuzer wrote: > > - (void) sprintf(fullname, "%s/%s", directory, name); > > + (void) snprintf(fullname, sizeof(filename), "%s/%s", directory, name); >

Re: Regression tests for usr.sbin/zic and lib/libc/stdtime

2008-04-02 Thread Steven Kreuzer
On Wed, Apr 02, 2008 at 10:54:08PM +1100, Edwin Groothuis wrote: > Greetings, > > I have make an attempt to upgrade the code in usr.sbin/zic and > lib/libc/stdtime from tzcode2004 to tzcode2008a. So far so good: I > have been able to apply most of the patches, it compiles and when > I rebooted the

Regression tests for usr.sbin/zic and lib/libc/stdtime

2008-04-02 Thread Edwin Groothuis
Greetings, I have make an attempt to upgrade the code in usr.sbin/zic and lib/libc/stdtime from tzcode2004 to tzcode2008a. So far so good: I have been able to apply most of the patches, it compiles and when I rebooted the machine it came back and all applications started up... Note that this is a

seemingly good gdbinit for freebsd kernel errors out

2008-04-02 Thread Sanjeev Kumar.S
Hi, Im trying to debug a gdb init script that errors out saying: too few arguments in function call Here is the script define kldload set $kld = linker_files.tqh_first set $done = 0 while ($kld != 0 && $done == 0) if ($kld->filename == $arg0) set $done = 1 else