Re: Wine 5.9 bugfix

2020-05-24 Thread Gerald Pfeifer
On Sat, 23 May 2020, Damjan Jovanovic wrote: > For Wine. I'll submit it upstream when the rtld-elf patch goes into > stable/12. What will happen to users on FreeBSD 11 (or 12 before the rtld-elf patch) when that additional patch goes into upstream Wine? Gerald

Re: Wine 5.9 bugfix

2020-05-24 Thread Konstantin Belousov
On Sun, May 24, 2020 at 05:29:55PM +0200, Damjan Jovanovic wrote: > On Sun, May 24, 2020 at 4:49 PM Konstantin Belousov > wrote: > > > On Sun, May 24, 2020 at 03:45:47PM +0200, Damjan Jovanovic wrote: > > > On Sun, May 24, 2020 at 3:40 PM Gerald Pfeifer > > wrote: > > > > > > > On Sat, 23 May 20

Re: Wine 5.9 bugfix

2020-05-24 Thread Gerald Pfeifer
On Sun, 24 May 2020, Damjan Jovanovic wrote: > This is the patch I would send, it effectively changes 2 lines to check an > extra condition (__FreeBSD_version < 1202000): > > > commit c81fc2e8dc75c5dcab300da4fa6cc6ccfb0c3d15 (freebsd-mmap) > Author: Damjan Jovanovic > Date: Sat May 23 13:49:31

Re: Wine 5.9 bugfix

2020-05-24 Thread Gerald Pfeifer
On Sun, 24 May 2020, Damjan Jovanovic wrote: >> I just started test builds of emulators/wine-devel with that patch. >> >> So far I have kept files/patch-tools-winegcc which reverts the upstream >> change (1ccd638b1aa85fb3c43b49d69d279cd509ebdc21) that kicked of this >> avalanche of events. I was t

Re: Wine 5.9 bugfix

2020-05-24 Thread Damjan Jovanovic
On Sun, May 24, 2020 at 4:49 PM Konstantin Belousov wrote: > On Sun, May 24, 2020 at 03:45:47PM +0200, Damjan Jovanovic wrote: > > On Sun, May 24, 2020 at 3:40 PM Gerald Pfeifer > wrote: > > > > > On Sat, 23 May 2020, Damjan Jovanovic wrote: > > > > For Wine. I'll submit it upstream when the rtl

Re: Wine 5.9 bugfix

2020-05-24 Thread Konstantin Belousov
On Sun, May 24, 2020 at 03:45:47PM +0200, Damjan Jovanovic wrote: > On Sun, May 24, 2020 at 3:40 PM Gerald Pfeifer wrote: > > > On Sat, 23 May 2020, Damjan Jovanovic wrote: > > > For Wine. I'll submit it upstream when the rtld-elf patch goes into > > > stable/12. > > > > What will happen to users

Re: Wine 5.9 bugfix

2020-05-24 Thread Damjan Jovanovic
On Sun, May 24, 2020 at 3:40 PM Gerald Pfeifer wrote: > On Sat, 23 May 2020, Damjan Jovanovic wrote: > > For Wine. I'll submit it upstream when the rtld-elf patch goes into > > stable/12. > > What will happen to users on FreeBSD 11 (or 12 before the rtld-elf > patch) when that additional patch go

Re: Wine 5.9 bugfix

2020-05-24 Thread Gerald Pfeifer
On Sat, 23 May 2020, Damjan Jovanovic wrote: > Wine 5.9 is out, and all 3 of the bugs in 5.7 - 5.8 that were affecting > FreeBSD should be fixed upstream now. Thank you for debugging and even fixing those, Damjan - and even doing so upstream! > However I accidentally introduced another bug recen

Re: Wine 5.9 bugfix

2020-05-23 Thread Damjan Jovanovic
On Sat, May 23, 2020 at 9:53 PM Gerald Pfeifer wrote: > On Sat, 23 May 2020, Damjan Jovanovic wrote: > > Wine 5.9 is out, and all 3 of the bugs in 5.7 - 5.8 that were affecting > > FreeBSD should be fixed upstream now. > > Thank you for debugging and even fixing those, Damjan - and even doing > s

Re: Wine 5.9 bugfix

2020-05-23 Thread Gerald Pfeifer
On Sat, 23 May 2020, Damjan Jovanovic wrote: >>> Also Konstantin and other developers have fixed that rtld-elf issue in >>> the base system by changing link_map.l_addr to work the way it does on >>> Linux/NetBSD/Illumos >> The fix should appear in stable/12 in one week, assuming no further >> reg

Re: Wine 5.9 bugfix

2020-05-23 Thread Damjan Jovanovic
On Sat, May 23, 2020 at 8:43 PM Gerald Pfeifer wrote: > On Sat, 23 May 2020, Damjan Jovanovic wrote: > >>> Also Konstantin and other developers have fixed that rtld-elf issue in > >>> the base system by changing link_map.l_addr to work the way it does on > >>> Linux/NetBSD/Illumos > >> The fix sh

Re: Wine 5.9 bugfix

2020-05-23 Thread Damjan Jovanovic
On Sat, May 23, 2020 at 1:16 PM Konstantin Belousov wrote: > On Sat, May 23, 2020 at 11:45:43AM +0200, Damjan Jovanovic wrote: > > Hi > > > > Wine 5.9 is out, and all 3 of the bugs in 5.7 - 5.8 that were affecting > > FreeBSD should be fixed upstream now. > > > > However I accidentally introduced

Re: Wine 5.9 bugfix

2020-05-23 Thread Konstantin Belousov
On Sat, May 23, 2020 at 11:45:43AM +0200, Damjan Jovanovic wrote: > Hi > > Wine 5.9 is out, and all 3 of the bugs in 5.7 - 5.8 that were affecting > FreeBSD should be fixed upstream now. > > However I accidentally introduced another bug recently, where we don't > check the return value from an mm

Wine 5.9 bugfix

2020-05-23 Thread Damjan Jovanovic
Hi Wine 5.9 is out, and all 3 of the bugs in 5.7 - 5.8 that were affecting FreeBSD should be fixed upstream now. However I accidentally introduced another bug recently, where we don't check the return value from an mmap() call, resulting in assertion failures and possibly memory corruption... I d