Re: sysvshm: replace Giant with a local sx lock

2013-05-15 Thread Konstantin Belousov
On Tue, May 14, 2013 at 10:13:05PM +0200, Mateusz Guzik wrote: > On Tue, Apr 23, 2013 at 11:36:21PM +0200, Mateusz Guzik wrote: > > On Tue, Apr 23, 2013 at 11:55:32PM +0300, Konstantin Belousov wrote: > > > On Tue, Apr 23, 2013 at 10:38:23PM +0200, Mateusz Guzik wrote: > > > > I would like to repla

Re: sysvshm: replace Giant with a local sx lock

2013-05-14 Thread Mateusz Guzik
On Tue, Apr 23, 2013 at 11:36:21PM +0200, Mateusz Guzik wrote: > On Tue, Apr 23, 2013 at 11:55:32PM +0300, Konstantin Belousov wrote: > > On Tue, Apr 23, 2013 at 10:38:23PM +0200, Mateusz Guzik wrote: > > > I would like to replace Giant with a local sx lock in sysvshm code. > > > Looked really stra

Re: sysvshm: replace Giant with a local sx lock

2013-04-23 Thread Mateusz Guzik
On Tue, Apr 23, 2013 at 11:55:32PM +0300, Konstantin Belousov wrote: > On Tue, Apr 23, 2013 at 10:38:23PM +0200, Mateusz Guzik wrote: > > I would like to replace Giant with a local sx lock in sysvshm code. > > Looked really straightforward so maybe I missed something. > > At very least, the shmget

Re: sysvshm: replace Giant with a local sx lock

2013-04-23 Thread Konstantin Belousov
On Tue, Apr 23, 2013 at 10:38:23PM +0200, Mateusz Guzik wrote: > Hello, > > I would like to replace Giant with a local sx lock in sysvshm code. > Looked really straightforward so maybe I missed something. At very least, the shmget_existing() is no longer functional. The sx is owned around tsleep(

sysvshm: replace Giant with a local sx lock

2013-04-23 Thread Mateusz Guzik
Hello, I would like to replace Giant with a local sx lock in sysvshm code. Looked really straightforward so maybe I missed something. Patch: http://people.freebsd.org/~mjg/patches/sysvshm-giant-sx.patch Inlined version for comments: diff --git a/sys/kern/sysv_shm.c b/sys/kern/sysv_shm.c index a1