Re: setfacl Recursive Functionality

2011-02-28 Thread Shawn Webb
One last patch before I do a send-pr to send the patch upstream. This patch depends on my ZFS ACL Sets patch for the -k flag. I wanted to zero-out the ACL entries recursively for a directory, which I can do in Solaris with "chmod -R A= /path/to/directory", but ZFS doesn't allow zero-number ACL sets

Re: setfacl Recursive Functionality

2011-02-10 Thread Shawn Webb
Attached is a new patch using the acl(3) API for removing invalid inheritance. Unless there are other suggestions, I'll likely submit this upstream. I didn't implement the -P flag since that's the default behavior. Thanks, Shawn On Wed, Feb 9, 2011 at 2:10 PM, Shawn Webb wrote: > Included in t

Re: setfacl Recursive Functionality

2011-02-09 Thread Shawn Webb
Included in the attached patch is the refactor using fts(3) and with the -L and -H options. I'm still looking for feedback and suggestions on how to improve the patch. I'll also port these changes over to my getfacl patch. If anyone's interested in following up-to-date development of the patch, th

Re: setfacl Recursive Functionality

2011-02-08 Thread Tim Kientzle
On Feb 8, 2011, at 9:58 AM, Shawn Webb wrote: > I've just finished a patch to add recursive functionality to setfacl. Before > I officially submit it, I'd like a few suggestions on how to improve the > patch. > > The part I'm worried about involves the #define directive at top. I'm not > sure what

Re: setfacl Recursive Functionality

2011-02-08 Thread Shawn Webb
On Tue, Feb 8, 2011 at 7:35 PM, Tim Kientzle wrote: > On Feb 8, 2011, at 9:58 AM, Shawn Webb wrote: > > I've just finished a patch to add recursive functionality to setfacl. > Before > > I officially submit it, I'd like a few suggestions on how to improve the > > patch. > > > > The part I'm worri

Re: setfacl Recursive Functionality

2011-02-08 Thread Shawn Webb
Attached is the patch. I'm also storing my FreeBSD patches at https://github.com/lattera/patches Thanks, Shawn On Tue, Feb 8, 2011 at 11:30 AM, Miroslav Lachman <000.f...@quip.cz> wrote: > Shawn Webb wrote: > >> I've just finished a patch to add recursive functionality to setfacl. >> Before >>

Re: setfacl Recursive Functionality

2011-02-08 Thread Miroslav Lachman
Shawn Webb wrote: I've just finished a patch to add recursive functionality to setfacl. Before I officially submit it, I'd like a few suggestions on how to improve the patch. The part I'm worried about involves the #define directive at top. I'm not sure what ramifications using that define might

setfacl Recursive Functionality

2011-02-08 Thread Shawn Webb
I've just finished a patch to add recursive functionality to setfacl. Before I officially submit it, I'd like a few suggestions on how to improve the patch. The part I'm worried about involves the #define directive at top. I'm not sure what ramifications using that define might have. I needed it f