Re: patches for if_iwi and wlan for WEP mode

On 8 March 2012 07:43, John Baldwin wrote: > However, you could do that by having a net80211_ifattach() type thing that > sets if_transmit and invokes the driver-provided if_start.  I don't think > wireless devices are using multiple transmit queues in such a way that > if_transmit would be a ben

Re: patches for if_iwi and wlan for WEP mode

On Wednesday, March 07, 2012 2:43:52 pm Adrian Chadd wrote: > On 7 March 2012 11:17, Bernhard Schmidt wrote: > > On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote: > >> .. except that the default if_transmit handling breaks fragments. Sigh. > >> > >> So we're going to have to implement if_trans

Re: patches for if_iwi and wlan for WEP mode

On 8 March 2012 09:32, Mitsuru IWASAKI wrote: > Hi, > >> I'd rather you didn't commit iwi_update_mcast() unless you absolutely >> know that the NIC doesn't need to be notified of multicast group >> membership changes. If so, please commit that as a separate fix. > > OK, I'd do so.  I don't need mc

Re: patches for if_iwi and wlan for WEP mode

Hi, > I'd rather you didn't commit iwi_update_mcast() unless you absolutely > know that the NIC doesn't need to be notified of multicast group > membership changes. If so, please commit that as a separate fix. OK, I'd do so. I don't need mcast stuff for the time being, instead I'd check other ar

Re: patches for if_iwi and wlan for WEP mode

> -- > > Message: 4 > Date: Wed, 7 Mar 2012 10:45:11 -0800 > From: Adrian Chadd > Subject: Re: patches for if_iwi and wlan for WEP mode > To: Mitsuru IWASAKI > Cc: freebsd-current@freebsd.org, freebsd-wirel...@freebsd.org, >        bschm.

Re: patches for if_iwi and wlan for WEP mode

It's on topic because he included that in his patch. :) Adrian Sent from my Palm Pre on AT&T On Mar 7, 2012 12:18 PM, Bernhard Schmidt wrote: On Wednesday 07 March 2012 19:45:11 Adrian Chadd wrote: > Hi, > > I'd rather you didn't commit iwi_update_mcast() unless yo

Re: patches for if_iwi and wlan for WEP mode

On Wednesday 07 March 2012 19:45:11 Adrian Chadd wrote: > Hi, > > I'd rather you didn't commit iwi_update_mcast() unless you absolutely > know that the NIC doesn't need to be notified of multicast group > membership changes. If so, please commit that as a separate fix. Oh well, iwi(4) receives mu

Re: patches for if_iwi and wlan for WEP mode

On 7 March 2012 11:17, Bernhard Schmidt wrote: > On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote: >> .. except that the default if_transmit handling breaks fragments. Sigh. >> >> So we're going to have to implement if_transmit for all net80211 >> drivers soon and fix fragment handling. > > No

Re: patches for if_iwi and wlan for WEP mode

On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote: > .. except that the default if_transmit handling breaks fragments. Sigh. > > So we're going to have to implement if_transmit for all net80211 > drivers soon and fix fragment handling. Not saying that you are wrong, it is unrelated to the issu

Re: patches for if_iwi and wlan for WEP mode

On Wednesday 07 March 2012 16:38:44 Mitsuru IWASAKI wrote: > So iwi_transmit and iwi_qflush would not be necessary. correct > Today's version of patches at: > http://people.freebsd.org/~iwasaki/iwi/iwi-20120307.diff > > This would be the final version I hope. I gave it a quick spin, works for m

Re: patches for if_iwi and wlan for WEP mode

Hi, I'd rather you didn't commit iwi_update_mcast() unless you absolutely know that the NIC doesn't need to be notified of multicast group membership changes. If so, please commit that as a separate fix. I'll look at iwi later and give you feedback on that particular change. Thanks for chasing t

Re: patches for if_iwi and wlan for WEP mode

> > In RELENG_7, data frame is transmitted by iwi_tx_start() like this. > > > > ether_output > > ether_output_frame > > IFQ_HANDOFF/IFQ_HANDOFF_ADJ > > if_start > > iwi_start > > iwi_tx_start > > > > After 8.0-RELEASE, device specific if_transmit() is cal

Re: patches for if_iwi and wlan for WEP mode

> I'd rather you file a PR first describing what you just did, then > commit the fix and close the PR. OK, I've just submitted a PR. I'll follow the procedure you suggested. http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/165819 Thanks ___ freebsd-cur

Re: patches for if_iwi and wlan for WEP mode

.. except that the default if_transmit handling breaks fragments. Sigh. So we're going to have to implement if_transmit for all net80211 drivers soon and fix fragment handling. Adrian On 6 March 2012 11:05, Bernhard Schmidt wrote: > On Tuesday 06 March 2012 18:30:46 Mitsuru IWASAKI wrote: >> T

Re: patches for if_iwi and wlan for WEP mode

On Tuesday 06 March 2012 18:30:46 Mitsuru IWASAKI wrote: > Thanks Bernhard and Adrian, I think the problem seems to be solved. > > > > My patches set IEEE80211_NODE_ASSOCID bit only if ni->ni_associd > > > is set. Any suggestions on this part are welcome. > > > > Are you sure the net80211 part i

Re: patches for if_iwi and wlan for WEP mode

Hi, I'd rather you file a PR first describing what you just did, then commit the fix and close the PR. Since you've found a problem, it sounds like a great reason to open a Problem Report. :) You can then link the commit against the PR so they reference each other. I've been doing it for my ath

Re: patches for if_iwi and wlan for WEP mode

Thanks Bernhard and Adrian, I think the problem seems to be solved. > > My patches set IEEE80211_NODE_ASSOCID bit only if ni->ni_associd > > is set. Any suggestions on this part are welcome. > > Are you sure the net80211 part is correct? It looks to me as if you > are just masking the real issue

Re: patches for if_iwi and wlan for WEP mode

On Monday 05 March 2012 18:42:12 Mitsuru IWASAKI wrote: > Hi, > > I've fixed iwi(4) so that Intel(R) PRO/Wireless 2915ABG work > in WEP mode, which seems to be broken since 8.0-RELEASE. > > The patches against HEAD at: > http://people.freebsd.org/~iwasaki/iwi/iwi-20120305.diff > > I'm not sure t

Re: patches for if_iwi and wlan for WEP mode

Hi! (cc'ing freebsd-wireless, where we try to talk about this kind of stuff...) On 5 March 2012 09:42, Mitsuru IWASAKI wrote: > Hi, > > I've fixed iwi(4) so that Intel(R) PRO/Wireless 2915ABG work > in WEP mode, which seems to be broken since 8.0-RELEASE. Thanks for looking into this! I've not

patches for if_iwi and wlan for WEP mode

Hi, I've fixed iwi(4) so that Intel(R) PRO/Wireless 2915ABG work in WEP mode, which seems to be broken since 8.0-RELEASE. The patches against HEAD at: http://people.freebsd.org/~iwasaki/iwi/iwi-20120305.diff I'm not sure that changes on ieee80211 layer are right fixes, but all of mbufs were disc