Re: newsyslog(8) should wait(2) for children

2002-05-02 Thread Terry Lambert
Maxim Konovalov wrote: > > > b) exit after all children have done only. > > > > > > In the current implementation newsyslog(8) forks and execs gzip(1) or > > > bzip2(1) and exits immediately. If a log file(s) is big enough the > > > compress_log() process(es) will work after newsyslog's death and

Re: newsyslog(8) should wait(2) for children

2002-05-02 Thread Maxim Konovalov
On 01:04-0700, May 2, 2002, Terry Lambert wrote: > Maxim Konovalov wrote: > > > [ ... patch to wait for children, but do nothing with the result ... ] > > > > > > Why not just set the signal handler for the child process > > > termination to "ignore", so that the child processes do > > > not beco

Re: newsyslog(8) should wait(2) for children

2002-05-02 Thread Terry Lambert
Maxim Konovalov wrote: > > [ ... patch to wait for children, but do nothing with the result ... ] > > > > Why not just set the signal handler for the child process > > termination to "ignore", so that the child processes do > > not become zombied in the first place, so it's not ever > > necessary

Re: newsyslog(8) should wait(2) for children

2002-05-01 Thread Maxim Konovalov
Terry, On 23:11-0700, May 1, 2002, Terry Lambert wrote: > Maxim Konovalov wrote: > > [ ... patch to wait for children, but do nothing with the result ... ] > > Yes. > > Why not just set the signal handler for the child process > termination to "ignore", so that the child processes do > not beco

Re: newsyslog(8) should wait(2) for children

2002-05-01 Thread Terry Lambert
Maxim Konovalov wrote: [ ... patch to wait for children, but do nothing with the result ... ] Yes. Why not just set the signal handler for the child process termination to "ignore", so that the child processes do not become zombied in the first place, so it's not ever necessary to do a useless

Re: newsyslog(8) should wait(2) for children

2002-05-01 Thread Dag-Erling Smorgrav
Maxim Konovalov <[EMAIL PROTECTED]> writes: > Does anyone object to the next patch: while (wait(NULL) > 0 || errno == EINTR) /* nothing */ ; DES -- Dag-Erling Smorgrav - [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current"

newsyslog(8) should wait(2) for children

2002-05-01 Thread Maxim Konovalov
Does anyone object to the next patch: Index: newsyslog.c === RCS file: /home/ncvs/src/usr.sbin/newsyslog/newsyslog.c,v retrieving revision 1.41 diff -u -r1.41 newsyslog.c --- newsyslog.c 10 Apr 2002 10:38:44 - 1.41 +++ news