Re: more endian.h breakage; patch included.

2000-10-27 Thread Bruce Evans
On Wed, 18 Oct 2000, Brian Somers wrote: > > On Mon, 16 Oct 2000, Brian Somers wrote: > > > ntohl() & ntonl() were previously wrong to return u_long. > > > > Not wrong. They have always been documented to return u_long. > > But if sizeof(u_long) != 4, this is wrong. It's not best, but not wro

Re: more endian.h breakage; patch included.

2000-10-18 Thread Garrett Wollman
< said: > It is strictly correct for POSIX.1-1990, but FreeBSD-2 never had the > requirement until now. POSIX.1-200x is relaxing similar requirements > (I'm not sure about this one), so it is too late to start enforcing it. Yes. All POSIX headers which are defined to use specific foo_t types a

Re: more endian.h breakage; patch included.

2000-10-18 Thread Brian Somers
> On Mon, 16 Oct 2000, Brian Somers wrote: > > > > On Sun, 15 Oct 2000, Steven G. Kargl wrote: > > > > > > > There is another patch needed in libdialog. > > > > > > No patches are needed in applications; endian.h should be unbroken. > > > > In what way ? > > endian.h shouldn't depend on or i

Re: more endian.h breakage; patch included.

2000-10-16 Thread Bruce Evans
On Mon, 16 Oct 2000, Brian Somers wrote: > > On Sun, 15 Oct 2000, Steven G. Kargl wrote: > > > > > There is another patch needed in libdialog. > > > > No patches are needed in applications; endian.h should be unbroken. > > In what way ? endian.h shouldn't depend on or include and its associ

Re: more endian.h breakage; patch included.

2000-10-16 Thread Brian Somers
> On Sun, 15 Oct 2000, Steven G. Kargl wrote: > > > There is another patch needed in libdialog. > > No patches are needed in applications; endian.h should be unbroken. In what way ? ntohl() & ntonl() were previously wrong to return u_long. They now return uint32_t (which requires sys/types.h).

Re: more endian.h breakage; patch included.

2000-10-15 Thread Tony Fleisher
On Mon, 16 Oct 2000, Bruce Evans wrote: > On Sun, 15 Oct 2000, Steve Kargl wrote: > > > Actually, in this case the endian.h change exposed a bug > > if the wait(2) manpage is correct. In particular, > > is required to occur before , which was missing in > > libdialog/prgbox.c and libc_r/uthre

Re: more endian.h breakage; patch included.

2000-10-15 Thread Bruce Evans
On Sun, 15 Oct 2000, Steve Kargl wrote: > Actually, in this case the endian.h change exposed a bug > if the wait(2) manpage is correct. In particular, > is required to occur before , which was missing in > libdialog/prgbox.c and libc_r/uthread/uthread_wait4.c. It is strictly correct for POSIX

Re: more endian.h breakage; patch included.

2000-10-15 Thread Steve Kargl
Bruce Evans wrote: > On Sun, 15 Oct 2000, Steven G. Kargl wrote: > > > There is another patch needed in libdialog. > > No patches are needed in applications; endian.h should be unbroken. > > However, including endian.h directly seems to be a bug. endian.h is not > documented in any section 3 m

Re: more endian.h breakage; patch included.

2000-10-15 Thread Bruce Evans
On Sun, 15 Oct 2000, Steven G. Kargl wrote: > There is another patch needed in libdialog. No patches are needed in applications; endian.h should be unbroken. However, including endian.h directly seems to be a bug. endian.h is not documented in any section 3 man page. The documented interface

more endian.h breakage; patch included.

2000-10-15 Thread Steven G. Kargl
There is another patch needed in libdialog. Steve *** /usr/src/lib/libc_r/uthread/uthread_wait4.c.origSun Oct 15 11:16:02 2000 --- /usr/src/lib/libc_r/uthread/uthread_wait4.c Sun Oct 15 11:16:45 2000 *** *** 32,37 --- 32,38 * $FreeBSD: src/lib/libc_r/uthread/uthread