Re: mlx5(4) jumbo receive

2018-04-26 Thread Ben RUBSON
On 26 Apr 2018, Rick Macklem wrote: Ryan Stone wrote: On Tue, Apr 24, 2018 at 4:55 AM, Konstantin Belousov >>wrote: +#ifndef MLX5E_MAX_RX_BYTES +#defineMLX5E_MAX_RX_BYTES MCLBYTES +#endif Why do you use a 2KB buffer rather than a PAGE_SIZE'd buffer? MJUMPAGESIZE should offer signifi

Re: mlx5(4) jumbo receive

2018-04-26 Thread Konstantin Belousov
On Wed, Apr 25, 2018 at 04:04:13PM -0400, Ryan Stone wrote: > On Tue, Apr 24, 2018 at 4:55 AM, Konstantin Belousov > wrote: > > +#ifndef MLX5E_MAX_RX_BYTES > > +#defineMLX5E_MAX_RX_BYTES MCLBYTES > > +#endif > > Why do you use a 2KB buffer rather than a PAGE_SIZE'd buffer? > MJUMPAGESIZE

Re: mlx5(4) jumbo receive

2018-04-25 Thread Rick Macklem
Ryan Stone wrote: >On Tue, Apr 24, 2018 at 4:55 AM, Konstantin Belousov >>>wrote: >> +#ifndef MLX5E_MAX_RX_BYTES >> +#defineMLX5E_MAX_RX_BYTES MCLBYTES >> +#endif > >Why do you use a 2KB buffer rather than a PAGE_SIZE'd buffer? >MJUMPAGESIZE should offer significantly better performance fo

Re: mlx5(4) jumbo receive

2018-04-25 Thread Ryan Stone
On Tue, Apr 24, 2018 at 4:55 AM, Konstantin Belousov wrote: > +#ifndef MLX5E_MAX_RX_BYTES > +#defineMLX5E_MAX_RX_BYTES MCLBYTES > +#endif Why do you use a 2KB buffer rather than a PAGE_SIZE'd buffer? MJUMPAGESIZE should offer significantly better performance for jumbo frames without incre

Re: mlx5(4) jumbo receive

2018-04-24 Thread Konstantin Belousov
On Tue, Apr 24, 2018 at 06:44:24AM -0700, Rodney W. Grimes wrote: > > Hello, > > the patch below is of interest for people who use Mellanox Connect-X/4 > > and 5 ethernet adapters and configure it for jumbo frames. The patch > > should improve the system behavior on low or fragmented memory situat

Re: mlx5(4) jumbo receive

2018-04-24 Thread Rodney W. Grimes
> Hello, > the patch below is of interest for people who use Mellanox Connect-X/4 > and 5 ethernet adapters and configure it for jumbo frames. The patch > should improve the system behavior on low or fragmented memory situations. > See the commit message for detailed description. Also, the patch

Re: mlx5(4) jumbo receive

2018-04-24 Thread Konstantin Belousov
On Tue, Apr 24, 2018 at 11:55:38AM +0200, Ben RUBSON wrote: > On 24 Apr, Konstantin Belousov wrote: > > > Hello, > > the patch below is of interest for people who use Mellanox Connect-X/4 > > and 5 ethernet adapters and configure it for jumbo frames. > > Hi Konstantin, > > Good news ! > Do you t

Re: mlx5(4) jumbo receive

2018-04-24 Thread Ben RUBSON
On 24 Apr, Konstantin Belousov wrote: Hello, the patch below is of interest for people who use Mellanox Connect-X/4 and 5 ethernet adapters and configure it for jumbo frames. Hi Konstantin, Good news ! Do you think your work could be easily ported to Connect-X/3 devices (mlx4 driver) ? Th

mlx5(4) jumbo receive

2018-04-24 Thread Konstantin Belousov
Hello, the patch below is of interest for people who use Mellanox Connect-X/4 and 5 ethernet adapters and configure it for jumbo frames. The patch should improve the system behavior on low or fragmented memory situations. See the commit message for detailed description. Also, the patch should not