Re: let badsect recog IFCHR in 5.0-C

2000-06-28 Thread Alexander Langer
Thus spake Warner Losh ([EMAIL PROTECTED]): > /* That's OK */ > #if 0 > That's not > #endif Lol. I'd like to see one who does such things :) Alex -- cat: /home/alex/.sig: No such file or directory To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body o

Re: let badsect recog IFCHR in 5.0-C

2000-06-28 Thread Clive Lin
On Wed, Jun 28, 2000 at 11:31:55AM +1000, Bruce Evans wrote: > 1) Don't "comment out" dead code. Remove it. > 2) Use only #if 0 to "comment out code. Comments are unsuitable for >"commenting out" code in general, because the code might contain >comments, and they are harder to edit and r

Re: let badsect recog IFCHR in 5.0-C

2000-06-28 Thread Warner Losh
In message <[EMAIL PROTECTED]> Alexander Langer writes: : Thus spake Dan Papasian ([EMAIL PROTECTED]): : : > > > + // un-needed. : > > > + // memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1); : > > > + // *name_dir_end = 'r'; : > > Use /* */ comments or #if 0. :

Re: let badsect recog IFCHR in 5.0-C

2000-06-27 Thread Bruce Evans
On Tue, 27 Jun 2000, Alexander Langer wrote: > Thus spake Clive Lin ([EMAIL PROTECTED]): > > > - memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1); > > - *name_dir_end = 'r'; > > + // un-needed. > > + // memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1); > >

Re: let badsect recog IFCHR in 5.0-C

2000-06-27 Thread Brian O'Shea
On Tue, Jun 27, 2000 at 06:14:31PM +0200, Alexander Langer wrote: > Thus spake Dan Papasian ([EMAIL PROTECTED]): > > > > > + // un-needed. > > > > + // memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1); > > > > + // *name_dir_end = 'r'; > > > Use /* */ comments or

Re: let badsect recog IFCHR in 5.0-C

2000-06-27 Thread Alexander Langer
Thus spake Dan Papasian ([EMAIL PROTECTED]): > > > + // un-needed. > > > + // memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1); > > > + // *name_dir_end = 'r'; > > Use /* */ comments or #if 0. > Actually, there was just a discussion on comp.lang.c about how > they aren't interchan

Re: let badsect recog IFCHR in 5.0-C

2000-06-27 Thread Dan Papasian
On Tue, Jun 27, 2000 at 05:38:21PM +0200, Alexander Langer wrote: > Thus spake Clive Lin ([EMAIL PROTECTED]): > > > - memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1); > > - *name_dir_end = 'r'; > > + // un-needed. > > + // memcpy(name_dir_end + 1, name_dir_end, strlen(nam

Re: let badsect recog IFCHR in 5.0-C

2000-06-27 Thread Alexander Langer
Thus spake Clive Lin ([EMAIL PROTECTED]): > - memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1); > - *name_dir_end = 'r'; > + // un-needed. > + // memcpy(name_dir_end + 1, name_dir_end, strlen(name_dir_end) + 1); > + // *name_dir_end = 'r'; Use /* */ comments o

let badsect recog IFCHR in 5.0-C

2000-06-27 Thread Clive Lin
Hi, Here is the diff for badsect(8) to recognize character device (IFCHR) rather than block device (IFBLK), since there's no block device in current. I don't know if there's any difference bewteen block and character device. So, I surly don't know if this will screw up any disk. But, it