Re: ifnet use after free

2018-09-07 Thread Shawn Webb
On Fri, Aug 24, 2018 at 06:19:55PM -0400, Shawn Webb wrote: > Hey All, > > Somewhere in the last month or so, a use after free was introduced. I > don't have the time right now to bisect the commits and figure out > which commit introduced the breakage. Attached is the core.txt (which > seems nons

Re: ifnet use after free

2018-08-25 Thread Matthew Macy
On Sat, Aug 25, 2018 at 12:10 PM Kristof Provost wrote: > You may be right about that. With memguard (on ifnet) it implicates pf: > > pfi_cleanup_vnet() at pfi_cleanup_vnet+0xa4/frame 0xfe084f775320 > vnet_pf_uninit() at vnet_pf_uninit+0x85f/frame 0xfe084f7757c0 > vnet_destroy() at vnet_d

Re: ifnet use after free

2018-08-25 Thread Kristof Provost
You may be right about that. With memguard (on ifnet) it implicates pf: pfi_cleanup_vnet() at pfi_cleanup_vnet+0xa4/frame 0xfe084f775320 vnet_pf_uninit() at vnet_pf_uninit+0x85f/frame 0xfe084f7757c0 vnet_destroy() at vnet_destroy+0x12c/frame 0xfe084f7757f0 prison_deref() at prison_der

Re: ifnet use after free

2018-08-25 Thread Matthew Macy
I'll take a look. But it's likely to not be the OP's issue. For future reference memguard on the memory type in question is extremely useful in catching use after free. -M On Sat, Aug 25, 2018 at 05:51 Kristof Provost wrote: > On 25 Aug 2018, at 0:47, Kristof Provost wrote: > > On 25 Aug 2018,

Re: ifnet use after free

2018-08-25 Thread Kristof Provost
On 25 Aug 2018, at 0:47, Kristof Provost wrote: On 25 Aug 2018, at 0:26, Matthew Macy wrote: On Fri, Aug 24, 2018 at 15:25 Shawn Webb wrote: Hey All, Somewhere in the last month or so, a use after free was introduced. I don't have the time right now to bisect the commits and figure out

Re: ifnet use after free

2018-08-24 Thread Kristof Provost
On 25 Aug 2018, at 0:26, Matthew Macy wrote: On Fri, Aug 24, 2018 at 15:25 Shawn Webb wrote: Hey All, Somewhere in the last month or so, a use after free was introduced. I don't have the time right now to bisect the commits and figure out which commit introduced the breakage. Attached is the

Re: ifnet use after free

2018-08-24 Thread Matthew Macy
On Fri, Aug 24, 2018 at 15:25 Shawn Webb wrote: > Hey All, > > Somewhere in the last month or so, a use after free was introduced. I > don't have the time right now to bisect the commits and figure out > which commit introduced the breakage. Attached is the core.txt (which > seems nonsensical bec