Re: i2c bit banging timeout for SCL

2019-10-22 Thread Andriy Gapon
Better late, than never: https://reviews.freebsd.org/D22109 This implements the configurable SCL low timeout with a new default and most of the discussed changes plus a little bit more. If you are interested, please feel free to join the review if you are not a reviewer already. -- Andriy Gap

Re: i2c bit banging timeout for SCL

2019-07-01 Thread Ian Lepore
On Mon, 2019-07-01 at 11:25 -0600, Warner Losh wrote: > On Mon, Jul 1, 2019 at 11:14 AM Poul-Henning Kamp > > wrote: > > > > > In message < > > canczdfofbvmxptnel4goqxtvp6zd-xrtja4rmuo1racy0jd...@mail.gmail.com> > > , > > Warner Losh writes: > > > > > The only issue, really, is that thi

Re: i2c bit banging timeout for SCL

2019-07-01 Thread Warner Losh
On Mon, Jul 1, 2019 at 11:14 AM Poul-Henning Kamp wrote: > > In message < > canczdfofbvmxptnel4goqxtvp6zd-xrtja4rmuo1racy0jd...@mail.gmail.com>, > Warner Losh writes: > > >The only issue, really, is that this timeout is a busy loop and there may > >be I/O bus contention introduced on the

Re: i2c bit banging timeout for SCL

2019-07-01 Thread Poul-Henning Kamp
In message , Warner Losh writes: >The only issue, really, is that this timeout is a busy loop and there may >be I/O bus contention introduced on these systems. Does it have to be a busy loop for the entire duration ? Spin for the median, timeout+poll for the rest of the time ? -- Po

Re: i2c bit banging timeout for SCL

2019-07-01 Thread Warner Losh
On Mon, Jul 1, 2019 at 10:30 AM Ian Lepore wrote: > On Mon, 2019-07-01 at 19:03 +0300, Andriy Gapon wrote: > > iicbb driver has a hardcoded timeout that defines how long the driver > waits for > > SCL line to go high after the driver releases it to float. Sometimes > slaves > > hold the line lo

Re: i2c bit banging timeout for SCL

2019-07-01 Thread Ian Lepore
On Mon, 2019-07-01 at 19:03 +0300, Andriy Gapon wrote: > iicbb driver has a hardcoded timeout that defines how long the driver waits > for > SCL line to go high after the driver releases it to float. Sometimes slaves > hold the line low until they are ready to continue with the communication. >

Re: i2c bit banging timeout for SCL

2019-07-01 Thread Andriy Gapon
On 01/07/2019 19:16, Poul-Henning Kamp wrote: > > In message , Andriy Gapon > writes: > >> iicbb driver has a hardcoded timeout that defines how long the driver waits >> for >> SCL line to go high after the driver releases it to float. Sometimes slaves >> hold the line low until they a

Re: i2c bit banging timeout for SCL

2019-07-01 Thread Poul-Henning Kamp
In message , Andriy Gapon writes: >iicbb driver has a hardcoded timeout that defines how long the driver waits for > SCL line to go high after the driver releases it to float. Sometimes slaves >hold the line low until they are ready to continue with the communication. >As a side note, t

i2c bit banging timeout for SCL

2019-07-01 Thread Andriy Gapon
iicbb driver has a hardcoded timeout that defines how long the driver waits for SCL line to go high after the driver releases it to float. Sometimes slaves hold the line low until they are ready to continue with the communication. As a side note, the timeout means that the driver just goes on a