Re: gccmakedep fix - 20130619

2013-06-18 Thread John Marino
On 6/19/2013 01:00, Oliver Pinter wrote: Hi all! Attached a fix to gccmakedep. So 1) There's already multiple PRs on this, including one I just submitted: http://www.freebsd.org/cgi/query-pr.cgi?pr=179571 2) Your patch adds an ".endif" which is already there 3) Is not it better to submi

Re: gccmakedep fix - 20130619

2013-06-18 Thread Mark Linimon
On Wed, Jun 19, 2013 at 01:51:42AM +0200, Oliver Pinter wrote: > > 3) Is not it better to submit via PR (GNATS) rather than a mailing list? > > That's what PRs are for... > > Mail are faster than PR-s. If we all go down that route, it means less and less people will try to read all the traffic

Re: gccmakedep fix - 20130619

2013-06-18 Thread Oliver Pinter
On 6/19/13, John Marino wrote: > On 6/19/2013 01:00, Oliver Pinter wrote: >> Hi all! >> >> Attached a fix to gccmakedep. > > > So > 1) There's already multiple PRs on this, including one I just submitted: > http://www.freebsd.org/cgi/query-pr.cgi?pr=179571 > > 2) Your patch adds an ".endif" wh

gccmakedep fix - 20130619

2013-06-18 Thread Oliver Pinter
Hi all! Attached a fix to gccmakedep. diff --git a/devel/gccmakedep/Makefile b/devel/gccmakedep/Makefile index b7e8cf6..07c3ef3 100644 --- a/devel/gccmakedep/Makefile +++ b/devel/gccmakedep/Makefile @@ -20,6 +20,7 @@ PLIST_FILES= bin/gccmakedep .if (${OSVERSION} >= 900506 && ${OSVERSION} < 10