Re: bug in big pipe code causing performance problems

2003-07-30 Thread Mike Silbersack
On Wed, 30 Jul 2003, Pierre Beyssac wrote: > On Wed, Jul 30, 2003 at 11:32:49PM +0200, Pierre Beyssac wrote: > > - if (space > 0 && (wpipe->pipe_buffer.cnt < PIPE_SIZE)) { > > + if (space > 0 > > + && wpipe->pipe_buffer.cnt < wpipe->pipe_buffer.size) { > > PS :

Re: bug in big pipe code causing performance problems

2003-07-30 Thread Pierre Beyssac
On Wed, Jul 30, 2003 at 11:32:49PM +0200, Pierre Beyssac wrote: > - if (space > 0 && (wpipe->pipe_buffer.cnt < PIPE_SIZE)) { > + if (space > 0 > + && wpipe->pipe_buffer.cnt < wpipe->pipe_buffer.size) { PS : not-so-obvious after all since the above is equival

bug in big pipe code causing performance problems

2003-07-30 Thread Pierre Beyssac
Hello, If no one objects to it, I'd like to commit the following ASAP. It fixes an obvious bug in the big pipe code, a discrepancy between how free space is calculated in write vs poll. The bug affects stable as well. The bug's implications are less obvious: it make write(2) on a non-blocking pip