Re: acpiconf -s 3 does not call acpi sleep event handlers

2018-08-02 Thread Conrad Meyer
For those not on the bug, this is being followed up in PR 230290. On Wed, Aug 1, 2018 at 10:27 PM, Johannes Lundberg wrote: > > > On Thu, Aug 2, 2018 at 06:20 Andriy Gapon wrote: >> >> On 02/08/2018 01:17, Conrad Meyer wrote: >> > I don't understand the concern. There is only one listener to th

Re: acpiconf -s 3 does not call acpi sleep event handlers

2018-08-02 Thread Ian Lepore
On Thu, 2018-08-02 at 08:20 +0300, Andriy Gapon wrote: > On 02/08/2018 01:17, Conrad Meyer wrote: > > > > I don't understand the concern.  There is only one listener to the > > event and it just invokes ReqSleepState, which is responsible for > > performing all suspend behavior.  The behavior is i

Re: acpiconf -s 3 does not call acpi sleep event handlers

2018-08-01 Thread Johannes Lundberg
On Thu, Aug 2, 2018 at 06:20 Andriy Gapon wrote: > On 02/08/2018 01:17, Conrad Meyer wrote: > > I don't understand the concern. There is only one listener to the > > event and it just invokes ReqSleepState, which is responsible for > > performing all suspend behavior. The behavior is identical

Re: acpiconf -s 3 does not call acpi sleep event handlers

2018-08-01 Thread Andriy Gapon
On 02/08/2018 01:17, Conrad Meyer wrote: > I don't understand the concern. There is only one listener to the > event and it just invokes ReqSleepState, which is responsible for > performing all suspend behavior. The behavior is identical between > lid close and acpiconf. Unless someone is adding

Re: acpiconf -s 3 does not call acpi sleep event handlers

2018-08-01 Thread Conrad Meyer
I don't understand the concern. There is only one listener to the event and it just invokes ReqSleepState, which is responsible for performing all suspend behavior. The behavior is identical between lid close and acpiconf. On Wed, Aug 1, 2018 at 3:00 PM, Johannes Lundberg wrote: > > > On Wed, A

Re: acpiconf -s 3 does not call acpi sleep event handlers

2018-08-01 Thread Conrad Meyer
ReqSleepState is the routine that takes care of suspend, not the eventhandler. I'm not sure what difference the proposed change is supposed to make. Best, Conrad On Wed, Aug 1, 2018 at 2:48 PM, Johannes Lundberg wrote: > > > On Wed, Aug 1, 2018 at 9:15 PM Conrad Meyer wrote: >> >> It seems del

Re: acpiconf -s 3 does not call acpi sleep event handlers

2018-08-01 Thread Johannes Lundberg
On Wed, Aug 1, 2018 at 22:55 Conrad Meyer wrote: > ReqSleepState is the routine that takes care of suspend, not the > eventhandler. I'm not sure what difference the proposed change is > supposed to make. Listeners to acpi_sleep_event don’t get the event when suspending with acpiconf (but they

Re: acpiconf -s 3 does not call acpi sleep event handlers

2018-08-01 Thread Johannes Lundberg
On Wed, Aug 1, 2018 at 9:15 PM Conrad Meyer wrote: > It seems deliberate, although the commit message does not call it out > and the event is perhaps poorly named. The event currently indicates > that the lid was closed. And the final registered eventhandler for > the event calls ReqSleepState.

Re: acpiconf -s 3 does not call acpi sleep event handlers

2018-08-01 Thread Conrad Meyer
It seems deliberate, although the commit message does not call it out and the event is perhaps poorly named. The event currently indicates that the lid was closed. And the final registered eventhandler for the event calls ReqSleepState. The ReqSleepState routine, as well as the userspace ioctl t

acpiconf -s 3 does not call acpi sleep event handlers

2018-08-01 Thread Johannes Lundberg
Hi As the title says, callbacks registered with EVENTHANDLER_REGISTER(acpi_sleep_event, does not get called when calling acpiconf -s 3. They do however, when suspending with lid or sleep button. Is this deliberate or an oversight? Cheers ___ freeb