Re: WITHOUT_PF breaks buildworld

2021-12-22 Thread Gary Jennejohn
On Wed, 22 Dec 2021 12:52:15 -0600 Warner Losh wrote: > On Wed, Dec 22, 2021, 12:37 PM Gary Jennejohn wrote: > [snip patch] > > > > Since pf.h is used so widely in the tree it's probably the simplest > > fix. > > > > > > > > > > I like this. I'd unconditionally remove the test in preferen

Re: WITHOUT_PF breaks buildworld

2021-12-22 Thread Warner Losh
On Wed, Dec 22, 2021, 12:37 PM Gary Jennejohn wrote: > On Wed, 22 Dec 2021 10:58:50 -0600 > Warner Losh wrote: > > > On Wed, Dec 22, 2021, 10:02 AM Gary Jennejohn > wrote: > > > > > > > > This simple patch to /usr/src/include/Makefile fixes it for me: > > > > > > --- Makefile.orig 2021-12

Re: WITHOUT_PF breaks buildworld

2021-12-22 Thread Gary Jennejohn
On Wed, 22 Dec 2021 10:58:50 -0600 Warner Losh wrote: > On Wed, Dec 22, 2021, 10:02 AM Gary Jennejohn wrote: > > > > > This simple patch to /usr/src/include/Makefile fixes it for me: > > > > --- Makefile.orig 2021-12-22 13:37:02.817745000 +0100 > > +++ Makefile2021-12-22 13:37:12.1773

Re: WITHOUT_PF breaks buildworld

2021-12-22 Thread Warner Losh
On Wed, Dec 22, 2021, 10:02 AM Gary Jennejohn wrote: > On Wed, 22 Dec 2021 16:51:54 +0100 > Gary Jennejohn wrote: > > On Wed, 22 Dec 2021 16:27:52 +0100 > Kristof Provost wrote: > > > On 22 Dec 2021, at 8:21, Konrad Sewi??o-Jopek wrote: > > > Hi, > > > > > > I think the reason is somewhere in t

Re: WITHOUT_PF breaks buildworld

2021-12-22 Thread Gary Jennejohn
On Wed, 22 Dec 2021 16:51:54 +0100 Gary Jennejohn wrote: On Wed, 22 Dec 2021 16:27:52 +0100 Kristof Provost wrote: > On 22 Dec 2021, at 8:21, Konrad Sewi??o-Jopek wrote: > > Hi, > > > > I think the reason is somewhere in tools/build/test-includes: > > > > --- net/if_pfsync.o --- > > In file i

Re: WITHOUT_PF breaks buildworld

2021-12-22 Thread Kristof Provost
On 22 Dec 2021, at 8:21, Konrad Sewiłło-Jopek wrote: > Hi, > > I think the reason is somewhere in tools/build/test-includes: > > --- net/if_pfsync.o --- > In file included from net/if_pfsync.c:1: > In file included from > [...]freebsd/arm64.aarch64/tmp/usr/include/net/if_pfsync.h:56: > [...]freebsd

Re: WITHOUT_PF breaks buildworld

2021-12-22 Thread Gary Jennejohn
On Wed, 22 Dec 2021 12:04:01 +0100 Gary Jennejohn wrote: > On Wed, 22 Dec 2021 08:21:35 +0100 > Konrad Sewi??o-Jopek wrote: > > > Hi, > > > > I think the reason is somewhere in tools/build/test-includes: > > > > --- net/if_pfsync.o --- > > In file included from net/if_pfsync.c:1: > > In file

Re: WITHOUT_PF breaks buildworld

2021-12-22 Thread Gary Jennejohn
On Wed, 22 Dec 2021 08:21:35 +0100 Konrad Sewi??o-Jopek wrote: > Hi, > > I think the reason is somewhere in tools/build/test-includes: > > --- net/if_pfsync.o --- > In file included from net/if_pfsync.c:1: > In file included from > [...]freebsd/arm64.aarch64/tmp/usr/include/net/if_pfsync.h:56:

Re: WITHOUT_PF breaks buildworld

2021-12-21 Thread Konrad Sewiłło-Jopek
Hi, I think the reason is somewhere in tools/build/test-includes: --- net/if_pfsync.o --- In file included from net/if_pfsync.c:1: In file included from [...]freebsd/arm64.aarch64/tmp/usr/include/net/if_pfsync.h:56: [...]freebsd/arm64.aarch64/tmp/usr/include/net/pfvar.h:65:10: fatal error: 'netpf

Re: WITHOUT_PF breaks buildworld

2021-12-19 Thread Gary Jennejohn
On Sun, 19 Dec 2021 19:05:35 +0800 Alastair Hogge wrote: > On Sunday, 19 December 2021 6:47:23 PM AWST Gary Jennejohn wrote: > > Some recent change, probably in a .mk file, breaks builworld on HEAD > > when WITHOUT_PF is enabled in src.conf. > > I have had to disable WITHOUT_PF since 2020-07-2

Re: WITHOUT_PF breaks buildworld

2021-12-19 Thread Alastair Hogge
On Sunday, 19 December 2021 6:47:23 PM AWST Gary Jennejohn wrote: > Some recent change, probably in a .mk file, breaks builworld on HEAD > when WITHOUT_PF is enabled in src.conf. I have had to disable WITHOUT_PF since 2020-07-27, but probably earlier. > Disabling WITHOUT_PF results in a successfu

WITHOUT_PF breaks buildworld

2021-12-19 Thread Gary Jennejohn
Some recent change, probably in a .mk file, breaks builworld on HEAD when WITHOUT_PF is enabled in src.conf. Disabling WITHOUT_PF results in a successful buildworld. The reported error is that netpfil/pf/pf.h can't be found. -- Gary Jennejohn