Re: The current libc/locale/toupper.c is mistaken

2012-05-10 Thread Kohji Okuno
Hi, I'm sorry. I forgot to attach a file. Regards, Kohji Okuno > Hi David, > > From: David Chisnall > >> If you have a test case, I can commit it to the libc++ test suite. >> >> David > > I attached my test source. > This test program shoud output as below. > > towupper_l > 0049, 0049 > 0

Re: The current libc/locale/toupper.c is mistaken

2012-05-10 Thread Kohji Okuno
Hi David, From: David Chisnall > If you have a test case, I can commit it to the libc++ test suite. > > David I attached my test source. This test program shoud output as below. towupper_l 0049, 0049 0131, 0049 0130, 0130 0069, 0049 towlower_l 0049, 0069 0131, 0131 0130, 0069 0069, 0069 But

Re: The current libc/locale/toupper.c is mistaken

2012-05-10 Thread David Chisnall
If you have a test case, I can commit it to the libc++ test suite. David On 10 May 2012, at 21:42, Kohji Okuno wrote: > Hi Eric, > >> I'm left wondering how this was not caught by the libc++ test >> suite. The current toupper.c shouldn't pass >> http://llvm.org/svn/llvm-project/libcxx/trunk/tes

Re: The current libc/locale/toupper.c is mistaken

2012-05-10 Thread Kohji Okuno
Hi Eric, > I'm left wondering how this was not caught by the libc++ test > suite. The current toupper.c shouldn't pass > http://llvm.org/svn/llvm-project/libcxx/trunk/test/localization/locales/locale.convenience/conversions/conversions.character/toupper.pass.cpp This test suite checks only popula

Re: The current libc/locale/toupper.c is mistaken

2012-05-10 Thread Erik Cederstrand
Den 10/05/2012 kl. 12.03 skrev Dimitry Andric: > On 2012-05-10 11:02, Kohji Okuno wrote: >> I think that libc/locale/toupper.c is mistaken. >> Could you check it? >> >> @@ -51,7 +51,7 @@ ___toupper_l(c, l) >> { >>size_t lim; >>FIX_LOCALE(l); >> - _RuneRange *rr = &XLOCALE_CT

Re: The current libc/locale/toupper.c is mistaken

2012-05-10 Thread Dimitry Andric
On 2012-05-10 11:02, Kohji Okuno wrote: > I think that libc/locale/toupper.c is mistaken. > Could you check it? > > @@ -51,7 +51,7 @@ ___toupper_l(c, l) > { > size_t lim; > FIX_LOCALE(l); > - _RuneRange *rr = &XLOCALE_CTYPE(l)->runes->__maplower_ext; > + _RuneRange *rr

Re: The current libc/locale/toupper.c is mistaken

2012-05-10 Thread Erik Cederstrand
Den 10/05/2012 kl. 11.54 skrev Erik Cederstrand: > Den 10/05/2012 kl. 11.02 skrev Kohji Okuno: > >> Hi, >> >> I think that libc/locale/toupper.c is mistaken. >> Could you check it? >> >> @@ -51,7 +51,7 @@ ___toupper_l(c, l) >> { >> size_t lim; >> FIX_LOCALE(l); >> - _RuneRange

Re: The current libc/locale/toupper.c is mistaken

2012-05-10 Thread Erik Cederstrand
Den 10/05/2012 kl. 11.02 skrev Kohji Okuno: > Hi, > > I think that libc/locale/toupper.c is mistaken. > Could you check it? > > @@ -51,7 +51,7 @@ ___toupper_l(c, l) > { >size_t lim; >FIX_LOCALE(l); > - _RuneRange *rr = &XLOCALE_CTYPE(l)->runes->__maplower_ext; > + _Ru

The current libc/locale/toupper.c is mistaken

2012-05-10 Thread Kohji Okuno
Hi, I think that libc/locale/toupper.c is mistaken. Could you check it? @@ -51,7 +51,7 @@ ___toupper_l(c, l) { size_t lim; FIX_LOCALE(l); - _RuneRange *rr = &XLOCALE_CTYPE(l)->runes->__maplower_ext; + _RuneRange *rr = &XLOCALE_CTYPE(l)->runes->__mapupper_ext;