Re: Clang buildworld failure due to multiple definitions of __isnanf

2011-06-30 Thread David Schultz
On Sun, Jun 26, 2011, Eric McCorkle wrote: > I've both seen reports and experienced make buildworld with clang > failing in usr.bin/xlint/lint1 (really, make kernel-toolchain is what > fails), because lint1 is statically linked, and there is a definition of > __isnanf in both libc and libm. GCC

Re: Clang buildworld failure due to multiple definitions of __isnanf

2011-06-28 Thread Garrett Cooper
On Tue, Jun 28, 2011 at 12:47 PM, Pan Tsu wrote: > Garrett Cooper writes: > > [...] >>> Just noticed, the CFLAGS would disable optimization, which would explain why >>> no one else seems to see this.  Still, I think the underlying issue warrants >>> investigation. >> >> Two things are wrong here:

Re: Clang buildworld failure due to multiple definitions of __isnanf

2011-06-28 Thread Garrett Cooper
On Mon, Jun 27, 2011 at 8:59 AM, Eric McCorkle wrote: > On 6/27/11 8:29 AM, Dimitry Andric wrote: >> >> On 2011-06-27 04:32, Eric McCorkle wrote: >>> >>> I've both seen reports and experienced make buildworld with clang >>> failing in usr.bin/xlint/lint1 (really, make kernel-toolchain is what >>>

Re: Clang buildworld failure due to multiple definitions of __isnanf

2011-06-28 Thread Eric McCorkle
On 6/28/11 1:42 AM, Benjamin Kaduk wrote: On Tue, 28 Jun 2011, Benjamin Kaduk wrote: On Mon, 27 Jun 2011, Eric McCorkle wrote: make.conf: CPUTYPE?=core2 .if !defined(CC) || ${CC} == "cc" CC=clang CFLAGS=-Qunused-arguments .endif .if !defined(CXX) || ${CXX} == "c++" CXX=clang++ .endif NO_WERRO

Re: Clang buildworld failure due to multiple definitions of __isnanf

2011-06-27 Thread Benjamin Kaduk
On Tue, 28 Jun 2011, Benjamin Kaduk wrote: On Mon, 27 Jun 2011, Eric McCorkle wrote: make.conf: CPUTYPE?=core2 .if !defined(CC) || ${CC} == "cc" CC=clang CFLAGS=-Qunused-arguments .endif .if !defined(CXX) || ${CXX} == "c++" CXX=clang++ .endif NO_WERROR= WERROR= NO_FSCHG= PERL_VERSION=5.12.3 J

Re: Clang buildworld failure due to multiple definitions of __isnanf

2011-06-27 Thread Benjamin Kaduk
On Mon, 27 Jun 2011, Eric McCorkle wrote: make.conf: CPUTYPE?=core2 .if !defined(CC) || ${CC} == "cc" CC=clang CFLAGS=-Qunused-arguments .endif .if !defined(CXX) || ${CXX} == "c++" CXX=clang++ .endif NO_WERROR= WERROR= NO_FSCHG= PERL_VERSION=5.12.3 Just noticed, the CFLAGS would disable optimiz

Re: Clang buildworld failure due to multiple definitions of __isnanf

2011-06-27 Thread Eric McCorkle
On 6/27/11 8:29 AM, Dimitry Andric wrote: On 2011-06-27 04:32, Eric McCorkle wrote: I've both seen reports and experienced make buildworld with clang failing in usr.bin/xlint/lint1 (really, make kernel-toolchain is what fails), because lint1 is statically linked, and there is a definition of __i

Re: Clang buildworld failure due to multiple definitions of __isnanf

2011-06-27 Thread Dimitry Andric
On 2011-06-27 04:32, Eric McCorkle wrote: I've both seen reports and experienced make buildworld with clang failing in usr.bin/xlint/lint1 (really, make kernel-toolchain is what fails), because lint1 is statically linked, and there is a definition of __isnanf in both libc and libm. GCC, on the o

Re: Clang buildworld failure due to multiple definitions of __isnanf

2011-06-26 Thread Steve Kargl
On Sun, Jun 26, 2011 at 10:32:02PM -0400, Eric McCorkle wrote: > > A better solution, I think, is to modify math.h with something like this: > > #ifdef __clang__ > #define isnan(n) __builtin_isnan(n) > ... > #endif Please, no. Don't touch math.h. -- Steve _