Re: RQ review: [was: Re: "make modules" kicks the first module directory twice]

2000-11-17 Thread David O'Brien
On Fri, Nov 17, 2000 at 10:55:32PM +0900, Makoto MATSUSHITA wrote: > Attached below is a patch which I've made before. If nothing is going > wrong, please commit this change I committed something simular. BTW, you made ``make depend'' a requirement, which we did not have agreement on. To

Re: RQ review: [was: Re: "make modules" kicks the first module directory twice]

2000-11-14 Thread Marcel Moolenaar
David O'Brien wrote: > > > > modules-depend: > > > @mkdir -p ${.OBJDIR}/modules > > > ! cd $S/modules; env ${MKMODULESENV} ${MAKE} obj > > > ! env ${MKMODULESENV} ${MAKE} depend > > This is broken for non -j case. Yes, this was known. The right diff was given at the beginn

Re: RQ review: [was: Re: "make modules" kicks the first module directory twice]

2000-11-14 Thread David O'Brien
On Mon, Nov 13, 2000 at 08:02:47PM -0800, Marcel Moolenaar wrote: > Any objections? Yes. > (patches follow for your convenience) [its easier to read patches when they aren't quoted in their entirety ;-)] > > modules-depend: > > @mkdir -p ${.OBJDIR}/modules > > ! cd $S/modules;

RQ review: [was: Re: "make modules" kicks the first module directory twice]

2000-11-13 Thread Marcel Moolenaar
Makoto MATSUSHITA wrote: > > Ouch... give me one more chance to submit a patch. Here's summary: I see no reason to not commit Makoto-san's patches with the fix he sent me for the modules-depend target. The fix is (modulo indentation): > modules-depend: > ! cd $S/modules; env ${MKMODULES